Bug 87410 - REGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests crash on Windows
Summary: REGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-24 11:41 PDT by Jessie Berlin
Modified: 2012-05-24 12:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2012-05-24 11:44 PDT, Jessie Berlin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2012-05-24 11:41:01 PDT 
http://trac.webkit.org/changeset/109663 explicitly ignored the comment in LocalizedStrings.cpp:

// Note that because |format| is used as the second parameter to va_start, it cannot be a reference 
// type according to section 18.7/3 of the C++ N1905 standard.

and changed the parameter to a const reference.

This caused crashes under CFStringCreateWithFormatAndArguments on Windows.
Comment 1 Jessie Berlin 2012-05-24 11:44:36 PDT 
Created attachment 143863 [details]
Patch
Comment 2 Jessie Berlin 2012-05-24 12:00:25 PDT 
Comment on attachment 143863 [details]
Patch

Committed in http://trac.webkit.org/changeset/118399
Comment 3 Radar WebKit Bug Importer 2012-05-24 12:41:40 PDT 
<rdar://problem/11527190>