Bug 87394 - Text Autosizing: Add compile flag and runtime setting
Summary: Text Autosizing: Add compile flag and runtime setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: John Mellor
URL:
Keywords:
Depends on:
Blocks: FontBoosting
  Show dependency treegraph
 
Reported: 2012-05-24 08:11 PDT by John Mellor
Modified: 2019-05-02 16:18 PDT (History)
12 users (show)

See Also:


Attachments
Patch (38.43 KB, patch)
2012-05-24 08:46 PDT, John Mellor
no flags Details | Formatted Diff | Diff
Patch (38.38 KB, patch)
2012-05-24 08:57 PDT, John Mellor
no flags Details | Formatted Diff | Diff
Patch (38.44 KB, patch)
2012-05-24 11:39 PDT, John Mellor
no flags Details | Formatted Diff | Diff
Rename (42.38 KB, patch)
2012-07-04 03:06 PDT, John Mellor
no flags Details | Formatted Diff | Diff
Rename and add compile guards (42.78 KB, patch)
2012-07-04 07:07 PDT, John Mellor
no flags Details | Formatted Diff | Diff
Rename and add compile guards (46.55 KB, patch)
2012-07-04 07:32 PDT, John Mellor
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Mellor 2012-05-24 08:11:47 PDT
Font Boosting: Add compile flag and runtime setting
Comment 1 John Mellor 2012-05-24 08:46:34 PDT
Created attachment 143838 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-24 08:48:44 PDT
Comment on attachment 143838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143838&action=review

Except for windows, looks fine.

> Source/WebKit/chromium/features.gypi:146
> +          'ENABLE_FONT_BOOSTING=1', # TODO: CHECK THIS

Check this?

> WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:101
> +		Value="ENABLE_FONT_BOOSTING"

I doubt Windows wants this on. :)

> WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:101
> +		Value="ENABLE_FONT_BOOSTING"

Similarly I suspect WinCairo wants it off.
Comment 3 John Mellor 2012-05-24 08:57:44 PDT
Created attachment 143839 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-05-24 08:59:30 PDT
Comment on attachment 143839 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-05-24 10:21:00 PDT
Comment on attachment 143839 [details]
Patch

Rejecting attachment 143839 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
aries/win/tools/vsprops/FeatureDefines.vsprops.rej
patching file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
Hunk #1 FAILED at 9.
Hunk #2 succeeded at 102 (offset 5 lines).
1 out of 2 hunks FAILED -- saving rejects to file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops.rej
patching file configure.ac

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12807160
Comment 6 Adam Barth 2012-05-24 10:31:56 PDT
@johnme: I can land this manually for you.
Comment 7 John Mellor 2012-05-24 10:34:58 PDT
(In reply to comment #6)
> @johnme: I can land this manually for you.

Thanks Adam. For future reference, what's the easiest way of rebasing a patch (preferably one that automatically resolves ChangeLogs)? I couldn't see any options for that on webkit-patch.
Comment 8 Adam Barth 2012-05-24 10:43:54 PDT
> Thanks Adam. For future reference, what's the easiest way of rebasing a patch (preferably one that automatically resolves ChangeLogs)? I couldn't see any options for that on webkit-patch.

It depends if you're using git or svn.  If you're using git, there's merge.changelog.driver.  If you're using SVN, then update-webkit and/or resolve-ChangeLogs works well.
Comment 9 John Mellor 2012-05-24 11:39:25 PDT
Created attachment 143862 [details]
Patch
Comment 10 Adam Barth 2012-05-24 11:41:17 PDT
Comment on attachment 143862 [details]
Patch

Forwarding Eric's r+
Comment 11 WebKit Review Bot 2012-05-24 11:45:14 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 12 WebKit Review Bot 2012-05-24 13:01:08 PDT
Comment on attachment 143862 [details]
Patch

Clearing flags on attachment: 143862

Committed r118407: <http://trac.webkit.org/changeset/118407>
Comment 13 WebKit Review Bot 2012-05-24 13:01:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 John Mellor 2012-07-04 03:01:31 PDT
Reopening bug since Simon Fraser asked to rename Font Boosting to Text Autosizing in bug 88655.
Comment 15 John Mellor 2012-07-04 03:06:58 PDT
Created attachment 150752 [details]
Rename

Renames Font Boosting to Text Autosizing
Comment 16 John Mellor 2012-07-04 07:07:32 PDT
Created attachment 150788 [details]
Rename and add compile guards

Renames Font Boosting to Text Autosizing. Also adds compile guards around the runtime settings.
Comment 17 John Mellor 2012-07-04 07:32:49 PDT
Created attachment 150791 [details]
Rename and add compile guards

Renames Font Boosting to Text Autosizing (now sorted in correct order). Also adds compile guards around the runtime settings.
Comment 18 WebKit Review Bot 2012-07-04 09:16:19 PDT
Comment on attachment 150791 [details]
Rename and add compile guards

Clearing flags on attachment: 150791

Committed r121861: <http://trac.webkit.org/changeset/121861>
Comment 19 WebKit Review Bot 2012-07-04 09:16:25 PDT
All reviewed patches have been landed.  Closing bug.