Bug 87382 – Web Inspector: convert HeapSnapshotGridNode._provider into getter.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

I found that we create a provider for child nodes for the each DataGrid node in advance.
It cost us one async call to the HeapSnapshot's worker per each such the node.
I converted the property into the getter which is initializing the provider lazily.

[Yury Semikhatsky]

You should be careful not to break DataGridNodeNode.hasChildren functionality for the heap profiler nodes. Some nodes use their providers to learn if it has children or not so the provider should exist when the node is being displayed.

[Ilya Tikhonovsky]

Created attachment 143809 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 143809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143809&action=review

> Source/WebCore/bindings/v8/ScriptHeapSnapshot.cpp:71
> +    int GetChunkSize() { return 102400; }

Please revert this.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:54
> +     * @return {WebInspector.HeapSnapshotProviderProxy|WebInspector.HeapSnapshotDiffNodesProvider}

WebInspector.HeapSnapshotDiffNodesProvider now extends WebInspector.HeapSnapshotProviderProxy so the annotation can be simplified.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:56
> +    _createProvider: function()

This should be public as it is overridden in the descendants.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:61
> +    get _provider()

Can you used provider() function instead of a getter?

[Yury Semikhatsky]

What is the performance impact of this change?

[Ilya Tikhonovsky]

Committed r118361: <http://trac.webkit.org/changeset/118361>