Bug 87378 - new test fast/js/dfg-arguments-mixed-alias.html fails on JSVALUE32_64
Summary: new test fast/js/dfg-arguments-mixed-alias.html fails on JSVALUE32_64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 86552 87008
  Show dependency treegraph
 
Reported: 2012-05-24 05:36 PDT by Kristóf Kosztyó
Modified: 2012-05-25 00:31 PDT (History)
5 users (show)

See Also:


Attachments
The diff from the qt bot (7.84 KB, text/plain)
2012-05-24 05:37 PDT, Kristóf Kosztyó
no flags Details
the patch (6.45 KB, patch)
2012-05-24 18:50 PDT, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2012-05-24 05:36:18 PDT
This test introduced in r118323. It fails on qt and gtk 32bit
Comment 1 Kristóf Kosztyó 2012-05-24 05:37:06 PDT
Created attachment 143796 [details]
The diff from the qt bot
Comment 2 Kristóf Kosztyó 2012-05-24 06:00:22 PDT
Committed r118356: <http://trac.webkit.org/changeset/118356>
Comment 3 Kristóf Kosztyó 2012-05-24 06:01:07 PDT
I've skipped this on qt.
Comment 4 Filip Pizlo 2012-05-24 18:45:39 PDT
I've gotten this to fail on 32-bit Mac as well.

Changed title to indicate this.

Patch on the way!
Comment 5 Filip Pizlo 2012-05-24 18:50:59 PDT
Created attachment 143948 [details]
the patch
Comment 6 Filip Pizlo 2012-05-24 20:31:00 PDT
Landed a fix in http://trac.webkit.org/changeset/118468

I'm going to mark this as fixed because I was able to repro failures on Mac 32-bit without this, and this patch fixes those failures. This change does NOT unskip any tests on Qt or Gtk though. Please reopen if those tests are still borked.
Comment 7 Csaba Osztrogonác 2012-05-25 00:31:24 PDT
Unskipped for Qt by r118486.