Bug 87361 – Web Inspector: Rule line numbers are not updated as properties are added/removed in the preceding rules

• Status: NEW
• Component: Web Inspector

[Alexander Pavlov (apavlov)]

Consider a stylesheet:

body {
}

div {
  margin: 2px;
}

If you add a property into the "body" rule, the "div" selector line is not updated in the Styles sidebar pane.

[Alexander Pavlov (apavlov)]

Created attachment 144789 [details]
Patch

[Build Bot]

Comment on attachment 144789 [details]
Patch

Attachment 144789 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12839988

[Alexander Pavlov (apavlov)]

Created attachment 144792 [details]
Patch

[Pavel Feldman]

Comment on attachment 144792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144792&action=review

> Source/WebCore/css/CSSStyleRule.cpp:125
> +    CSSStyleSheet::RuleMutationScope mutationScope(this);

You should not mutate CSSOM.

[Pavel Feldman]

Comment on attachment 144792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144792&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:432
> +                    rulesById[this._cssIdAsString(ruleArray[i].id)] = ruleArray[i];

Why do we need this mapping? It adds a bit of complexity to the code.

[Alexander Pavlov (apavlov)]

(In reply to comment #5)
> (From update of attachment 144792 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144792&action=review
> 
> > Source/WebCore/inspector/front-end/StylesSidebarPane.js:432
> > +                    rulesById[this._cssIdAsString(ruleArray[i].id)] = ruleArray[i];
> 
> Why do we need this mapping? It adds a bit of complexity to the code.

OK, let me explain what is going on here. It was a first stab at the task and I agree it looks somewhat awkward.

When committing property values, only the computed style is retrieved, and property overrides are recalculated across all matched rules. Obviously, the computed style does not give any matched rules line delta, so we need to get the matched rules for the focused element and use their data to retrieve the updated selector lines in the source. We might want to retrieve all matched rules instead of this two-step scheme - wdyt?

[Pavel Feldman]

Comment on attachment 144792 [details]
Patch

Clearing r? from the obsolete patch.

[Brian Burg]

Still reproduces.. :(

[Radar WebKit Bug Importer]

<rdar://problem/19107130>