Bug 87354 - Move StyleSheetContents to a separate file
Summary: Move StyleSheetContents to a separate file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 01:22 PDT by Antti Koivisto
Modified: 2012-05-24 01:53 PDT (History)
7 users (show)

See Also:

Attachments
patch (95.27 KB, patch)
2012-05-24 01:44 PDT, Antti Koivisto 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-05-24 01:22:32 PDT 
Yeah.
Comment 1 Antti Koivisto 2012-05-24 01:44:05 PDT 
Created attachment 143760 [details]
patch
Comment 2 WebKit Review Bot 2012-05-24 01:46:49 PDT 
Attachment 143760 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/css/StyleSheetContents.cpp:145:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/css/StyleSheetContents.cpp:198:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/css/StyleSheetContents.cpp:231:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2012-05-24 01:47:11 PDT 
Comment on attachment 143760 [details]
patch

Yay!
Comment 4 Antti Koivisto 2012-05-24 01:53:59 PDT 
http://trac.webkit.org/changeset/118336