RESOLVED FIXED 87354
Move StyleSheetContents to a separate file 
https://bugs.webkit.org/show_bug.cgi?id=87354
Summary Move StyleSheetContents to a separate file
Antti Koivisto
Reported 2012-05-24 01:22:32 PDT
Yeah.
Attachments
patch (95.27 KB, patch)
2012-05-24 01:44 PDT, Antti Koivisto 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-05-24 01:44:05 PDT
Created attachment 143760 [details] patch
WebKit Review Bot
Comment 2 2012-05-24 01:46:49 PDT
Attachment 143760 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/css/StyleSheetContents.cpp:145: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/css/StyleSheetContents.cpp:198: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/css/StyleSheetContents.cpp:231: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2012-05-24 01:47:11 PDT
Comment on attachment 143760 [details] patch Yay!
Antti Koivisto
Comment 4 2012-05-24 01:53:59 PDT
http://trac.webkit.org/changeset/118336
Note You need to log in before you can comment on or make changes to this bug.