Bug 87346 - Web Inspector: introduce console proxy object for HeapSnapshot worker.
Summary: Web Inspector: introduce console proxy object for HeapSnapshot worker.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 23:39 PDT by Ilya Tikhonovsky
Modified: 2012-05-24 06:10 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.48 KB, patch)
2012-05-23 23:47 PDT, Ilya Tikhonovsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-23 23:39:18 PDT 
There is no console object in html5 workers at the moment.
This makes me sad when I'm troubleshooting the HeapSnapshot stuff.
Comment 1 Ilya Tikhonovsky 2012-05-23 23:47:21 PDT 
Created attachment 143745 [details]
Patch
Comment 2 Pavel Feldman 2012-05-24 04:13:41 PDT 
Comment on attachment 143745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143745&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:67
> +            window[message.object][message.method].apply(window[message.object], message.arguments);

You should call methods on console only, otherwise, worker can run arbitrary code on the front-end which is effectively the reversed dependency.
Comment 3 Ilya Tikhonovsky 2012-05-24 04:26:18 PDT 
Committed r118348: <http://trac.webkit.org/changeset/118348>
Comment 4 Ilya Tikhonovsky 2012-05-24 06:10:55 PDT 
(In reply to comment #2)
> (From update of attachment 143745 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143745&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:67
> > +            window[message.object][message.method].apply(window[message.object], message.arguments);
> 
> You should call methods on console only, otherwise, worker can run arbitrary code on the front-end which is effectively the reversed dependency.

comment addressed