RESOLVED FIXED 87346
Web Inspector: introduce console proxy object for HeapSnapshot worker. 
https://bugs.webkit.org/show_bug.cgi?id=87346
Summary Web Inspector: introduce console proxy object for HeapSnapshot worker.
Ilya Tikhonovsky
Reported 2012-05-23 23:39:18 PDT
There is no console object in html5 workers at the moment. This makes me sad when I'm troubleshooting the HeapSnapshot stuff.
Attachments
Patch (3.48 KB, patch)
2012-05-23 23:47 PDT, Ilya Tikhonovsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-23 23:47:21 PDT
Created attachment 143745 [details] Patch
Pavel Feldman
Comment 2 2012-05-24 04:13:41 PDT
Comment on attachment 143745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143745&action=review > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:67 > + window[message.object][message.method].apply(window[message.object], message.arguments); You should call methods on console only, otherwise, worker can run arbitrary code on the front-end which is effectively the reversed dependency.
Ilya Tikhonovsky
Comment 3 2012-05-24 04:26:18 PDT
Committed r118348: <http://trac.webkit.org/changeset/118348>
Ilya Tikhonovsky
Comment 4 2012-05-24 06:10:55 PDT
(In reply to comment #2) > (From update of attachment 143745 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143745&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:67 > > + window[message.object][message.method].apply(window[message.object], message.arguments); > > You should call methods on console only, otherwise, worker can run arbitrary code on the front-end which is effectively the reversed dependency. comment addressed
Note You need to log in before you can comment on or make changes to this bug.