Bug 87342 – Elements in Shadow DOM is not resizable.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

When an element has CSS { resize: 'both' }, it should be resizable.
However if it is in Shadow DOM, it cannot be resizable.

[Shinya Kawanaka]

Actually the root cause of this issue is the same as bug 82568, but this is testable...

[Shinya Kawanaka]

Created attachment 143733 [details]
Patch

[Shinya Kawanaka]

Unfortunately I couldn't succeed testing textarea in Shadow DOM yet. It should be resizable by this patch, however I cannot confirm it in DRT... Writing a test for it should be done in Bug 82568, I think.

[Ryosuke Niwa]

Comment on attachment 143733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143733&action=review

> Source/WebCore/ChangeLog:3
> +        Elements in Shadow DOM is not resizable.

Nit: ARE not resizable.

> Source/WebCore/rendering/RenderLayer.cpp:1858
> +    Element* element = static_cast<Element*>(renderer()->node());

Don't we have toElement? We should at least assert that node() is Element*.

> LayoutTests/ChangeLog:3
> +        Elements in Shadow DOM is not resizable.

Ditto: are.

> LayoutTests/fast/dom/shadow/resize-in-shadow-dom.html:6
> +<script src="resources/polyfill.js"></script>
> +<script src="../resources/event-sender-util.js"></script>
> +<script src="../../js/resources/js-test-pre.js"></script>

You can put all of this in the body instead.

> LayoutTests/fast/dom/shadow/resize-in-shadow-dom.html:40
> +var element = document.elementFromPoint(x, y);

Why do we need this statement here?

[Shinya Kawanaka]

Created attachment 143738 [details]
Patch for landing

[Shinya Kawanaka]

(In reply to comment #4)
> (From update of attachment 143733 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143733&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Elements in Shadow DOM is not resizable.
> 
> Nit: ARE not resizable.
> 
> > Source/WebCore/rendering/RenderLayer.cpp:1858
> > +    Element* element = static_cast<Element*>(renderer()->node());
> 
> Don't we have toElement? We should at least assert that node() is Element*.
> 
> > LayoutTests/ChangeLog:3
> > +        Elements in Shadow DOM is not resizable.
> 
> Ditto: are.
> 
> > LayoutTests/fast/dom/shadow/resize-in-shadow-dom.html:6
> > +<script src="resources/polyfill.js"></script>
> > +<script src="../resources/event-sender-util.js"></script>
> > +<script src="../../js/resources/js-test-pre.js"></script>
> 
> You can put all of this in the body instead.
> 
> > LayoutTests/fast/dom/shadow/resize-in-shadow-dom.html:40
> > +var element = document.elementFromPoint(x, y);
> 
> Why do we need this statement here?

Thanks for very fast review! I've updated the patch. I will land it after the bots become green.

[WebKit Review Bot]

Comment on attachment 143738 [details]
Patch for landing

Clearing flags on attachment: 143738

Committed r118338: <http://trac.webkit.org/changeset/118338>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.