WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87340
Web Inspector: Breakpoints Pane should not show context menu with no breakpoints
https://bugs.webkit.org/show_bug.cgi?id=87340
Summary
Web Inspector: Breakpoints Pane should not show context menu with no breakpoints
Vivek Galatage
Reported
2012-05-23 22:12:49 PDT
Breakpoints Pane should not show context menu with no breakpoints
Attachments
Patch
(2.33 KB, patch)
2012-05-23 22:30 PDT
,
Vivek Galatage
no flags
Details
Formatted Diff
Diff
Patch
(2.29 KB, patch)
2012-05-24 05:53 PDT
,
Vivek Galatage
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Vivek Galatage
Comment 1
2012-05-23 22:30:04 PDT
Created
attachment 143730
[details]
Patch
Pavel Feldman
Comment 2
2012-05-24 04:16:33 PDT
Comment on
attachment 143730
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=143730&action=review
> Source/WebCore/inspector/front-end/BreakpointManager.js:141 > + breakpointsCount: function()
Nit: I would call it breakpointCount, but this is also ok. Also, you really want hasBreakpoints() here!
Vivek Galatage
Comment 3
2012-05-24 05:53:05 PDT
Created
attachment 143805
[details]
Patch
WebKit Review Bot
Comment 4
2012-05-24 07:49:26 PDT
Comment on
attachment 143805
[details]
Patch Clearing flags on attachment: 143805 Committed
r118371
: <
http://trac.webkit.org/changeset/118371
>
WebKit Review Bot
Comment 5
2012-05-24 07:49:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug