Bug 87340 - Web Inspector: Breakpoints Pane should not show context menu with no breakpoints
Summary: Web Inspector: Breakpoints Pane should not show context menu with no breakpoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 22:12 PDT by Vivek Galatage
Modified: 2012-05-24 07:49 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2012-05-23 22:30 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2012-05-24 05:53 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-05-23 22:12:49 PDT 
Breakpoints Pane should not show context menu with no breakpoints
Comment 1 Vivek Galatage 2012-05-23 22:30:04 PDT 
Created attachment 143730 [details]
Patch
Comment 2 Pavel Feldman 2012-05-24 04:16:33 PDT 
Comment on attachment 143730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143730&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:141
> +    breakpointsCount: function() 

Nit: I would call it breakpointCount, but this is also ok. Also, you really want hasBreakpoints() here!
Comment 3 Vivek Galatage 2012-05-24 05:53:05 PDT 
Created attachment 143805 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-24 07:49:26 PDT 
Comment on attachment 143805 [details]
Patch

Clearing flags on attachment: 143805

Committed r118371: <http://trac.webkit.org/changeset/118371>
Comment 5 WebKit Review Bot 2012-05-24 07:49:34 PDT 
All reviewed patches have been landed.  Closing bug.