Bug 8734 - Would like a Vector::append that takes another Vector
Summary: Would like a Vector::append that takes another Vector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks: 6638
  Show dependency treegraph
 
Reported: 2006-05-04 11:02 PDT by Anders Carlsson
Modified: 2006-05-04 13:32 PDT (History)
0 users

See Also:


Attachments
Implement function (1.47 KB, patch)
2006-05-04 11:07 PDT, Anders Carlsson
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2006-05-04 11:02:59 PDT
The xpath implementation uses a lot of Vectors for keeping track of node sets. It'd be nice to have an append function that takes another Vector as this it's something that's done commonly in the xpath code
Comment 1 Anders Carlsson 2006-05-04 11:07:03 PDT
Created attachment 8107 [details]
Implement function

This function works for me, but I'm not sure how correct it is. It doesn't support appending the vector to itself, but I don't know if we need that
Comment 2 Maciej Stachowiak 2006-05-04 13:17:19 PDT
Comment on attachment 8107 [details]
Implement function

Looks good to me. A more general version that takes start and end iterator might also be handy (and could be used to implement this one.