Range::createDocumentFragmentForElement, createFragmentFromSource (one in markup.cpp and another one in XSLTProcessor.cpp), and HTMLElement::insertAdjacentHTML all have very similar code, and the different between createDocumentFragmentForElement and two versions of createFragmentFromSource is not clear at all from function names.
Created attachment 143727 [details] Cleanup
Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12799051
Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12792080
Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12807008
Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12805037
Created attachment 143736 [details] Fixed build
Comment on attachment 143736 [details] Fixed build Attachment 143736 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12798101 New failing tests: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html fast/dynamic/insertAdjacentHTML.html fast/dom/HTMLElement/insertAdjacentHTML-errors.html
Created attachment 143748 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 143736 [details] Fixed build Attachment 143736 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12795105 New failing tests: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html fast/dynamic/insertAdjacentHTML.html fast/dom/HTMLElement/insertAdjacentHTML-errors.html
Created attachment 143754 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 143755 [details] Fixed a bug
Comment on attachment 143755 [details] Fixed a bug Attachment 143755 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12792125
Comment on attachment 143755 [details] Fixed a bug Attachment 143755 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12799101
Comment on attachment 143755 [details] Fixed a bug Qt doesn't like you.
Created attachment 143844 [details] Fixed Qt build
Comment on attachment 143844 [details] Fixed Qt build Thanks!
Comment on attachment 143844 [details] Fixed Qt build Clearing flags on attachment: 143844 Committed r118414: <http://trac.webkit.org/changeset/118414>
All reviewed patches have been landed. Closing bug.
Comment on attachment 143844 [details] Fixed Qt build View in context: https://bugs.webkit.org/attachment.cgi?id=143844&action=review > Source/WebCore/editing/markup.h:56 > + PassRefPtr<DocumentFragment> createContextualFragment(const String&, Element*, FragmentScriptingPermission); I noticed an extra space after a comma here. > Source/WebCore/html/HTMLElement.cpp:581 > + ExceptionCode ignoredEc = 0; // FIXME: We should propagate a syntax error exception out here. Should be ignoredEC.
Comment on attachment 143844 [details] Fixed Qt build View in context: https://bugs.webkit.org/attachment.cgi?id=143844&action=review >> Source/WebCore/editing/markup.h:56 >> + PassRefPtr<DocumentFragment> createContextualFragment(const String&, Element*, FragmentScriptingPermission); > > I noticed an extra space after a comma here. Fixing it in https://bugs.webkit.org/show_bug.cgi?id=87454. >> Source/WebCore/html/HTMLElement.cpp:581 >> + ExceptionCode ignoredEc = 0; // FIXME: We should propagate a syntax error exception out here. > > Should be ignoredEC. Ditto.