Bug 87338 – REGRESSION(r118297): It caused several layout failures on Mac (Requested by sundiamonde on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/118297 broke the build:
It caused several layout failures on Mac (Requested by sundiamonde on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 143717 [details]
ROLLOUT of r118297

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Stephanie Lewis]

The test caused several layout test to fail on Mac.  See http://build.webkit.org/results/Lion%20Release%20(WebKit2%20Tests)/r118303%20(7493)/results.html

+fast/block/float/floats-with-margin-should-not-wrap.html
+fast/forms/001.html
+fast/frames/flattening/iframe-tiny.html	expected
+fast/html/details-position.html
+fast/replaced/width100percent-checkbox.html
+fast/replaced/width100percent-radio.html
+svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm
+tables/mozilla/bugs/bug1318.html
+tables/mozilla/bugs/bug4527.html

Example diff:
--- /Volumes/Data/slave/lion-intel-release-tests-wk2/build/layout-test-results/fast/forms/001-expected.txt
+++ /Volumes/Data/slave/lion-intel-release-tests-wk2/build/layout-test-results/fast/forms/001-actual.txt
@@ -19,16 +19,16 @@
         RenderTable {TABLE} at (0,0) size 784x24 [border: (2px outset #808080)]
           RenderTableSection {TBODY} at (2,2) size 780x20
             RenderTableRow {TR} at (0,0) size 780x20
-              RenderTableCell {TD} at (0,0) size 20x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+              RenderTableCell {TD} at (0,0) size 18x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
                 RenderBlock {INPUT} at (3,4) size 12x12
-              RenderTableCell {TD} at (20,9) size 760x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+              RenderTableCell {TD} at (18,9) size 762x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
       RenderBlock {P} at (0,200) size 784x24
         RenderTable {TABLE} at (0,0) size 784x24 [border: (2px outset #808080)]
           RenderTableSection {TBODY} at (2,2) size 780x20
             RenderTableRow {TR} at (0,0) size 780x20
-              RenderTableCell {TD} at (0,0) size 20x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+              RenderTableCell {TD} at (0,0) size 18x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
                 RenderBlock {INPUT} at (3,4) size 12x12
-              RenderTableCell {TD} at (20,9) size 760x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+              RenderTableCell {TD} at (18,9) size 762x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
       RenderBlock {P} at (0,240) size 784x28
         RenderTable {TABLE} at (0,0) size 784x28 [border: (2px outset #808080)]
           RenderTableSection {TBODY} at (2,2) size 780x24

[WebKit Review Bot]

Comment on attachment 143717 [details]
ROLLOUT of r118297

Clearing flags on attachment: 143717

Committed r118318: <http://trac.webkit.org/changeset/118318>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Emil A Eklund]

(In reply to comment #2)
> The test caused several layout test to fail on Mac.  See http://build.webkit.org/results/Lion%20Release%20(WebKit2%20Tests)/r118303%20(7493)/results.html
> 
> +fast/block/float/floats-with-margin-should-not-wrap.html
> +fast/forms/001.html
> +fast/frames/flattening/iframe-tiny.html    expected
> +fast/html/details-position.html
> +fast/replaced/width100percent-checkbox.html
> +fast/replaced/width100percent-radio.html
> +svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm
> +tables/mozilla/bugs/bug1318.html
> +tables/mozilla/bugs/bug4527.html

fast/block/float/floats-with-margin-should-not-wrap.html was caused by this change the other tests though fail without the patch as well. Will fix the new test and re-land.

[Stephanie Lewis]

Can you explain what you mean by the other tests are failing anyway?  I verified on my personal machine that the tests starting failing with 118297.  The tests stopped failing on the bots after the rollout.

* +fast/frames/flattening/iframe-tiny.html   This test had just became flaky and is not related.

[Emil A Eklund]

(In reply to comment #6)
> Can you explain what you mean by the other tests are failing anyway?  I verified on my personal machine that the tests starting failing with 118297.  The tests stopped failing on the bots after the rollout.
> 
> * +fast/frames/flattening/iframe-tiny.html   This test had just became flaky and is not related.

I fail exactly the same set of tests with and without the patch. I tried on two different (mac) machines and got the same results on both.

[Emil A Eklund]

Argh, ignore my previous comment.

There are certain tests that will need to have the text expectations rebaselined on some versions of mac, basically having the margin rebaselines from r115573 reverted. Sadly I forgot to include those baselines in the patch, which caused this confusion. I do apologize about that.

[Emil A Eklund]

And just for the record, rolling the change back was the right thing to do regardless as the new test was failing.