Bug 87335 - sort the array 'non_wrapper_types'
Summary: sort the array 'non_wrapper_types'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lu Guanqun
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 19:49 PDT by Lu Guanqun
Modified: 2012-05-23 22:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2012-05-23 19:50 PDT, Lu Guanqun 		no flags Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2012-05-23 21:12 PDT, Lu Guanqun 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lu Guanqun 2012-05-23 19:49:27 PDT 
sort the array 'non_wrapper_types'
Comment 1 Lu Guanqun 2012-05-23 19:50:26 PDT 
Created attachment 143710 [details]
Patch
Comment 2 Lu Guanqun 2012-05-23 19:51:11 PDT 
It's done via 'sort' command in Vim. Only few key strokes. :)
Comment 3 Kentaro Hara 2012-05-23 19:56:25 PDT 
Comment on attachment 143710 [details]
Patch

Looks good. If you want to have the patch be reviewed, please change "r" to "r?".
Comment 4 WebKit Review Bot 2012-05-23 20:46:53 PDT 
Comment on attachment 143710 [details]
Patch

Attachment 143710 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12794062
Comment 5 Lu Guanqun 2012-05-23 21:12:47 PDT 
Created attachment 143722 [details]
Patch
Comment 6 Kentaro Hara 2012-05-23 21:15:36 PDT 
Comment on attachment 143722 [details]
Patch

OK.

Please change "cq" to "cq?" if you want to commit it. Then I can change "cq?" to "cq+".
Comment 7 WebKit Review Bot 2012-05-23 22:24:02 PDT 
Comment on attachment 143722 [details]
Patch

Clearing flags on attachment: 143722

Committed r118322: <http://trac.webkit.org/changeset/118322>
Comment 8 WebKit Review Bot 2012-05-23 22:24:14 PDT 
All reviewed patches have been landed.  Closing bug.