WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87335
sort the array 'non_wrapper_types'
https://bugs.webkit.org/show_bug.cgi?id=87335
Summary
sort the array 'non_wrapper_types'
Lu Guanqun
Reported
2012-05-23 19:49:27 PDT
sort the array 'non_wrapper_types'
Attachments
Patch
(2.17 KB, patch)
2012-05-23 19:50 PDT
,
Lu Guanqun
no flags
Details
Formatted Diff
Diff
Patch
(2.20 KB, patch)
2012-05-23 21:12 PDT
,
Lu Guanqun
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Lu Guanqun
Comment 1
2012-05-23 19:50:26 PDT
Created
attachment 143710
[details]
Patch
Lu Guanqun
Comment 2
2012-05-23 19:51:11 PDT
It's done via 'sort' command in Vim. Only few key strokes. :)
Kentaro Hara
Comment 3
2012-05-23 19:56:25 PDT
Comment on
attachment 143710
[details]
Patch Looks good. If you want to have the patch be reviewed, please change "r" to "r?".
WebKit Review Bot
Comment 4
2012-05-23 20:46:53 PDT
Comment on
attachment 143710
[details]
Patch
Attachment 143710
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/12794062
Lu Guanqun
Comment 5
2012-05-23 21:12:47 PDT
Created
attachment 143722
[details]
Patch
Kentaro Hara
Comment 6
2012-05-23 21:15:36 PDT
Comment on
attachment 143722
[details]
Patch OK. Please change "cq" to "cq?" if you want to commit it. Then I can change "cq?" to "cq+".
WebKit Review Bot
Comment 7
2012-05-23 22:24:02 PDT
Comment on
attachment 143722
[details]
Patch Clearing flags on attachment: 143722 Committed
r118322
: <
http://trac.webkit.org/changeset/118322
>
WebKit Review Bot
Comment 8
2012-05-23 22:24:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug