Bug 87329 – enable chromium port of webkitLineDash feature

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Canvas

[Lu Guanqun]

The v8 port of webkitLineDash feature is missing, implement it.

[Lu Guanqun]

Created attachment 143700 [details]
Patch

[Lu Guanqun]

With this feature, the dashed test can be shown. http://www.geogebra.org/web/test42/?f=_dashed.ggb

[Kentaro Hara]

Comment on attachment 143700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143700&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:77
>          attribute [Custom] Array webkitLineDash;

Wouldn't it be possible to generate the code by code generators? (Some change might be needed in CodeGeneratorV8.pm though.)

webkitLineDashAccessorSetter and webkitLineDashAccessorGetter are just setting/getting values to/from Arrays, which I think should be generated by code generators.

[Lu Guanqun]

(In reply to comment #3)
> (From update of attachment 143700 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143700&action=review
> 
> > Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:77
> >          attribute [Custom] Array webkitLineDash;
> 
> Wouldn't it be possible to generate the code by code generators? (Some change might be needed in CodeGeneratorV8.pm though.)
> 
> webkitLineDashAccessorSetter and webkitLineDashAccessorGetter are just setting/getting values to/from Arrays, which I think should be generated by code generators.

The original problem, as I recall, is that it uses non-standard type 'DashArray' to hold the values. But let me check how it can be done in CodeGeneratorV8.pm, thanks for your suggestion.

[Justin Novosad]

Has there been any progress on this?

[Justin Novosad]

The standard lineDash feature will make webkitLineDash obsolete.
See: https://bugs.webkit.org/show_bug.cgi?id=82560