Bug 87329 - enable chromium port of webkitLineDash feature
Summary: enable chromium port of webkitLineDash feature
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lu Guanqun
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 18:36 PDT by Lu Guanqun
Modified: 2012-09-04 12:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.08 KB, patch)
2012-05-23 18:39 PDT, Lu Guanqun 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lu Guanqun 2012-05-23 18:36:21 PDT 
The v8 port of webkitLineDash feature is missing, implement it.
Comment 1 Lu Guanqun 2012-05-23 18:39:27 PDT 
Created attachment 143700 [details]
Patch
Comment 2 Lu Guanqun 2012-05-23 18:46:58 PDT 
With this feature, the dashed test can be shown. http://www.geogebra.org/web/test42/?f=_dashed.ggb
Comment 3 Kentaro Hara 2012-05-23 18:49:06 PDT 
Comment on attachment 143700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143700&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:77
>          attribute [Custom] Array webkitLineDash;

Wouldn't it be possible to generate the code by code generators? (Some change might be needed in CodeGeneratorV8.pm though.)

webkitLineDashAccessorSetter and webkitLineDashAccessorGetter are just setting/getting values to/from Arrays, which I think should be generated by code generators.
Comment 4 Lu Guanqun 2012-05-23 19:18:09 PDT 
(In reply to comment #3)
> (From update of attachment 143700 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143700&action=review
> 
> > Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:77
> >          attribute [Custom] Array webkitLineDash;
> 
> Wouldn't it be possible to generate the code by code generators? (Some change might be needed in CodeGeneratorV8.pm though.)
> 
> webkitLineDashAccessorSetter and webkitLineDashAccessorGetter are just setting/getting values to/from Arrays, which I think should be generated by code generators.

The original problem, as I recall, is that it uses non-standard type 'DashArray' to hold the values. But let me check how it can be done in CodeGeneratorV8.pm, thanks for your suggestion.
Comment 5 Justin Novosad 2012-08-28 11:30:11 PDT 
Has there been any progress on this?
Comment 6 Justin Novosad 2012-09-04 12:50:26 PDT 
The standard lineDash feature will make webkitLineDash obsolete.
See: https://bugs.webkit.org/show_bug.cgi?id=82560