Bug 87326 - Qt DRT should be able to load external resources
Summary: Qt DRT should be able to load external resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on: 88227
Blocks: 84008
  Show dependency treegraph
 
Reported: 2012-05-23 17:16 PDT by Ryosuke Niwa
Modified: 2012-06-18 14:24 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch (3.96 KB, patch)
2012-06-01 08:29 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
proposed patch (3.94 KB, patch)
2012-06-06 03:32 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-05-23 17:16:23 PDT
For the purpose of page loading tests I'm preparing for the bug 84008, we need Qt DRT and WRT to be able to load external resources.
i.e. we need to make changes like http://trac.webkit.org/changeset/118231
Comment 1 Csaba Osztrogonác 2012-05-23 23:28:56 PDT
As far as I remember we have a working patch for it somewhere. Maybe Zoltán you have it. :)
Comment 2 Csaba Osztrogonác 2012-05-29 23:03:00 PDT
Balázs, Zoltán, don't we have a patch for this already?
Comment 3 Zoltan Horvath 2012-06-01 06:11:59 PDT
Assigned to me. I finished the patch, now I'm just testing it with WTR since we have crashes.
Comment 4 Zoltan Horvath 2012-06-01 08:29:33 PDT
Created attachment 145315 [details]
proposed patch

WTR crashes for URL parameters without this patch also, so that is a separate issue, so I upload the patch for r?.
Comment 5 Zoltan Horvath 2012-06-04 04:26:20 PDT
Comment on attachment 145315 [details]
proposed patch

Clearing flags on attachment: 145315

Committed r119384: <http://trac.webkit.org/changeset/119384>
Comment 6 Zoltan Horvath 2012-06-04 04:26:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2012-06-04 05:08:05 PDT
Re-opened since this is blocked by 88227
Comment 8 Zoltan Horvath 2012-06-06 03:32:36 PDT
Created attachment 145981 [details]
proposed patch

Same as last time. I just need to add an extra condition to make things right!
Tests pass to me on my system.
Comment 9 Zoltan Horvath 2012-06-06 04:21:56 PDT
Comment on attachment 145981 [details]
proposed patch

Clearing flags on attachment: 145981

Committed r119582: <http://trac.webkit.org/changeset/119582>
Comment 10 Zoltan Horvath 2012-06-06 04:22:06 PDT
All reviewed patches have been landed.  Closing bug.