RESOLVED FIXED 87325
[chromium/mac] Unbreak popup menus. 
https://bugs.webkit.org/show_bug.cgi?id=87325
Summary [chromium/mac] Unbreak popup menus.
Nico Weber
Reported 2012-05-23 17:02:43 PDT
[chromium/mac] Unbreak popup menus.
Attachments
Patch (1.93 KB, patch)
2012-05-23 17:03 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2012-05-23 17:15 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-05-23 17:03:11 PDT
Created attachment 143685 [details] Patch
Nico Weber
Comment 2 2012-05-23 17:07:10 PDT
http://svn.webkit.org/repository/webkit/trunk@117607 added this function. The Chromium/Mac build doesn't use the file added in that change. Adding it doesn't help, as the category calls a 10.7-only function. Just don't use the category for chromium/mac.
David Levin
Comment 3 2012-05-23 17:10:21 PDT
Comment on attachment 143685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143685&action=review > Source/WebCore/platform/mac/WebCoreNSCellExtras.m:25 > +#include "config.h" I think you can remove this.
David Levin
Comment 4 2012-05-23 17:11:52 PDT
(In reply to comment #2) > http://svn.webkit.org/repository/webkit/trunk@117607 added this function. The Chromium/Mac build doesn't use the file added in that change. Adding it doesn't help, as the category calls a 10.7-only function. Just don't use the category for chromium/mac. It would be nice if this explanation was in the change log as it is much more informative than what is in there now!
Nico Weber
Comment 5 2012-05-23 17:15:53 PDT
Created attachment 143688 [details] Patch
Nico Weber
Comment 6 2012-05-23 17:16:22 PDT
(In reply to comment #3) > (From update of attachment 143685 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143685&action=review > > > Source/WebCore/platform/mac/WebCoreNSCellExtras.m:25 > > +#include "config.h" > > I think you can remove this. Thanks. I had an oldish WebKit checkout (from bisecting), and my checkout didn't have that line yet. Rebased.
WebKit Review Bot
Comment 7 2012-05-23 19:40:31 PDT
Comment on attachment 143688 [details] Patch Clearing flags on attachment: 143688 Committed r118312: <http://trac.webkit.org/changeset/118312>
WebKit Review Bot
Comment 8 2012-05-23 19:40:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.