Bug 87325 - [chromium/mac] Unbreak popup menus.
Summary: [chromium/mac] Unbreak popup menus.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 17:02 PDT by Nico Weber
Modified: 2012-05-23 19:40 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.93 KB, patch)
2012-05-23 17:03 PDT, Nico Weber
no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2012-05-23 17:15 PDT, Nico Weber
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2012-05-23 17:02:43 PDT
[chromium/mac] Unbreak popup menus.
Comment 1 Nico Weber 2012-05-23 17:03:11 PDT
Created attachment 143685 [details]
Patch
Comment 2 Nico Weber 2012-05-23 17:07:10 PDT
http://svn.webkit.org/repository/webkit/trunk@117607 added this function. The Chromium/Mac build doesn't use the file added in that change. Adding it doesn't help, as the category calls a 10.7-only function. Just don't use the category for chromium/mac.
Comment 3 David Levin 2012-05-23 17:10:21 PDT
Comment on attachment 143685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143685&action=review

> Source/WebCore/platform/mac/WebCoreNSCellExtras.m:25
> +#include "config.h"

I think you can remove this.
Comment 4 David Levin 2012-05-23 17:11:52 PDT
(In reply to comment #2)
> http://svn.webkit.org/repository/webkit/trunk@117607 added this function. The Chromium/Mac build doesn't use the file added in that change. Adding it doesn't help, as the category calls a 10.7-only function. Just don't use the category for chromium/mac.

It would be nice if this explanation was in the change log as it is much more informative than what is in there now!
Comment 5 Nico Weber 2012-05-23 17:15:53 PDT
Created attachment 143688 [details]
Patch
Comment 6 Nico Weber 2012-05-23 17:16:22 PDT
(In reply to comment #3)
> (From update of attachment 143685 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143685&action=review
> 
> > Source/WebCore/platform/mac/WebCoreNSCellExtras.m:25
> > +#include "config.h"
> 
> I think you can remove this.

Thanks. I had an oldish WebKit checkout (from bisecting), and my checkout didn't have that line yet. Rebased.
Comment 7 WebKit Review Bot 2012-05-23 19:40:31 PDT
Comment on attachment 143688 [details]
Patch

Clearing flags on attachment: 143688

Committed r118312: <http://trac.webkit.org/changeset/118312>
Comment 8 WebKit Review Bot 2012-05-23 19:40:36 PDT
All reviewed patches have been landed.  Closing bug.