Bug 87309 - Refactor SVGAnimateTransformElement to avoid expensive determineAnimatedPropertyType call
Summary: Refactor SVGAnimateTransformElement to avoid expensive determineAnimatedPrope...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Philip Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 13:52 PDT by Philip Rogers
Modified: 2012-05-24 08:30 PDT (History)
3 users (show)

See Also:

Attachments
Avoid expensive determineAnimatedPropertyType call (2.41 KB, patch)
2012-05-23 14:05 PDT, Philip Rogers 		no flags Details | Formatted Diff | Diff
Fixed changelog (2.41 KB, patch)
2012-05-23 14:07 PDT, Philip Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2012-05-23 13:52:30 PDT 
This is a minor refactor of SVGAnimateTransformElement::hasValidAttributeType() to use m_animatedPropertyType instead of computing it on the fly. This same optimization was done in https://bugs.webkit.org/show_bug.cgi?id=75096 for SVGAnimateElement.

Patch forthcoming.
Comment 1 Philip Rogers 2012-05-23 14:05:32 PDT 
Created attachment 143646 [details]
Avoid expensive determineAnimatedPropertyType call
Comment 2 Philip Rogers 2012-05-23 14:07:15 PDT 
Created attachment 143648 [details]
Fixed changelog
Comment 3 Nikolas Zimmermann 2012-05-23 23:44:30 PDT 
Comment on attachment 143648 [details]
Fixed changelog

Good idea, r=me!
Comment 4 WebKit Review Bot 2012-05-24 08:30:24 PDT 
Comment on attachment 143648 [details]
Fixed changelog

Clearing flags on attachment: 143648

Committed r118379: <http://trac.webkit.org/changeset/118379>
Comment 5 WebKit Review Bot 2012-05-24 08:30:28 PDT 
All reviewed patches have been landed.  Closing bug.