Form control elements are mouse focusable only in QT and GTK ports. Test expectation for EFL port need to be updated.
Created attachment 143613 [details] Patch updated test expectations unskipped failing test case
Comment on attachment 143613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143613&action=review > LayoutTests/ChangeLog:8 > + Added platform specific test expectation. Nit: This is redundant, since there's a line saying "Added" below. > LayoutTests/ChangeLog:9 > + Unskip passing test. Nit: This could be moved to the line related to Skipped below. > LayoutTests/platform/efl/fast/events/click-focus-control-expected.txt:8 > +FAIL Some form elements didn't get focus Have you verified this failure is expected for the port? It'd be good to explain in the ChangeLog why.
Created attachment 143735 [details] Patch Made changes according to review comments
(In reply to comment #2) > Have you verified this failure is expected for the port? It'd be good to explain in the ChangeLog why. bool HTMLFormControlElement::isMouseFocusable() const { #if PLATFORM(GTK) || PLATFORM(QT) return HTMLElement::isMouseFocusable(); #else return false; #endif } and bool HTMLInputElement::isMouseFocusable() const { if (isTextField()) return HTMLTextFormControlElement::isFocusable(); return HTMLTextFormControlElement::isMouseFocusable(); } If form control element is not a text field, it won't be focusable. Only GTK and QT ports support that.
Comment on attachment 143735 [details] Patch OK.
Comment on attachment 143735 [details] Patch Clearing flags on attachment: 143735 Committed r118388: <http://trac.webkit.org/changeset/118388>
All reviewed patches have been landed. Closing bug.