Bug 87295 - [EFL] Update test expectations for layout test fast/events/click-focus-control.html
Summary: [EFL] Update test expectations for layout test fast/events/click-focus-contro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Shalamov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 11:54 PDT by Alexander Shalamov
Modified: 2012-05-29 12:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2012-05-23 12:15 PDT, Alexander Shalamov
no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2012-05-23 22:47 PDT, Alexander Shalamov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Shalamov 2012-05-23 11:54:48 PDT
Form control elements are mouse focusable only in QT and GTK ports. Test expectation for EFL port need to be updated.
Comment 1 Alexander Shalamov 2012-05-23 12:15:29 PDT
Created attachment 143613 [details]
Patch

updated test expectations
unskipped failing test case
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-23 12:36:07 PDT
Comment on attachment 143613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143613&action=review

> LayoutTests/ChangeLog:8
> +        Added platform specific test expectation.

Nit: This is redundant, since there's a line saying "Added" below.

> LayoutTests/ChangeLog:9
> +        Unskip passing test.

Nit: This could be moved to the line related to Skipped below.

> LayoutTests/platform/efl/fast/events/click-focus-control-expected.txt:8
> +FAIL Some form elements didn't get focus

Have you verified this failure is expected for the port? It'd be good to explain in the ChangeLog why.
Comment 3 Alexander Shalamov 2012-05-23 22:47:14 PDT
Created attachment 143735 [details]
Patch

Made changes according to review comments
Comment 4 Alexander Shalamov 2012-05-23 22:51:36 PDT
(In reply to comment #2)
> Have you verified this failure is expected for the port? It'd be good to explain in the ChangeLog why.

bool HTMLFormControlElement::isMouseFocusable() const
{
#if PLATFORM(GTK) || PLATFORM(QT)
    return HTMLElement::isMouseFocusable();
#else
    return false;
#endif
}

and 

bool HTMLInputElement::isMouseFocusable() const
{
    if (isTextField())
        return HTMLTextFormControlElement::isFocusable();
    return HTMLTextFormControlElement::isMouseFocusable();
}

If form control element is not a text field, it won't be focusable. Only GTK and QT ports support that.
Comment 5 Eric Seidel (no email) 2012-05-24 09:07:57 PDT
Comment on attachment 143735 [details]
Patch

OK.
Comment 6 WebKit Review Bot 2012-05-24 10:17:22 PDT
Comment on attachment 143735 [details]
Patch

Clearing flags on attachment: 143735

Committed r118388: <http://trac.webkit.org/changeset/118388>
Comment 7 WebKit Review Bot 2012-05-24 10:17:27 PDT
All reviewed patches have been landed.  Closing bug.