Bug 87293 - [EFL] Update test expectations for layout test fast/events/click-focus-anchor.html
Summary: [EFL] Update test expectations for layout test fast/events/click-focus-anchor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Shalamov
URL:
Keywords:
: 87090 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-23 11:52 PDT by Alexander Shalamov
Modified: 2012-05-28 01:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2012-05-23 12:03 PDT, Alexander Shalamov 		no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2012-05-23 12:23 PDT, Alexander Shalamov 		no flags Details | Formatted Diff | Diff
Patch (5.41 KB, patch)
2012-05-23 22:40 PDT, Alexander Shalamov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Shalamov 2012-05-23 11:52:04 PDT 
Anchor element is mouse focusable for QT, GTK and EFL ports, therefore, test expectations file need to be updated.
Comment 1 Alexander Shalamov 2012-05-23 12:03:57 PDT 
Created attachment 143611 [details]
Patch

added platform specific test expectation
Comment 2 Alexander Shalamov 2012-05-23 12:23:13 PDT 
Created attachment 143614 [details]
Patch

Unskip test
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-23 12:34:17 PDT 
Comment on attachment 143614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143614&action=review

> LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt:3
> +The expected result is platform specific. GTK and QT allows all links to be mouse focusable.

I'd change the actual test to mention EFL here as well (applies to the "a3" line below too).
Comment 4 Alexander Shalamov 2012-05-23 22:40:45 PDT 
Created attachment 143734 [details]
Patch

Made changes according to review comments
Comment 5 Eric Seidel (no email) 2012-05-24 09:26:18 PDT 
Comment on attachment 143734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143734&action=review

> LayoutTests/fast/events/click-focus-anchor-expected.txt:3
> +The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.

I would have changed this to say "some platforms", as some future platform may want this behavior or not. :)
Comment 6 WebKit Review Bot 2012-05-24 10:23:36 PDT 
Comment on attachment 143734 [details]
Patch

Clearing flags on attachment: 143734

Committed r118390: <http://trac.webkit.org/changeset/118390>
Comment 7 WebKit Review Bot 2012-05-24 10:23:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Jussi Kukkonen (jku) 2012-05-28 01:43:11 PDT 
*** Bug 87090 has been marked as a duplicate of this bug. ***