WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87272
Rename StyleSheetInternal to StyleSheetContents
https://bugs.webkit.org/show_bug.cgi?id=87272
Summary
Rename StyleSheetInternal to StyleSheetContents
Antti Koivisto
Reported
2012-05-23 10:01:15 PDT
It is a better name.
Attachments
patch
(80.84 KB, patch)
2012-05-23 10:07 PDT
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2012-05-23 10:07:40 PDT
Created
attachment 143587
[details]
patch
WebKit Review Bot
Comment 2
2012-05-23 10:10:37 PDT
Attachment 143587
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.h:81: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSParser.cpp:1102: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSStyleSheet.cpp:599: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2012-05-23 10:11:28 PDT
Comment on
attachment 143587
[details]
patch r$=me
Antti Koivisto
Comment 4
2012-05-24 01:55:22 PDT
This was
http://trac.webkit.org/changeset/118194
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug