Bug 87272 - Rename StyleSheetInternal to StyleSheetContents
Summary: Rename StyleSheetInternal to StyleSheetContents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 10:01 PDT by Antti Koivisto
Modified: 2012-05-24 01:55 PDT (History)
7 users (show)

See Also:


Attachments
patch (80.84 KB, patch)
2012-05-23 10:07 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-05-23 10:01:15 PDT
It is a better name.
Comment 1 Antti Koivisto 2012-05-23 10:07:40 PDT
Created attachment 143587 [details]
patch
Comment 2 WebKit Review Bot 2012-05-23 10:10:37 PDT
Attachment 143587 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.h:81:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.cpp:1102:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSheet.cpp:599:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2012-05-23 10:11:28 PDT
Comment on attachment 143587 [details]
patch

r$=me
Comment 4 Antti Koivisto 2012-05-24 01:55:22 PDT
This was http://trac.webkit.org/changeset/118194