Bug 87270 - Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce WebInspector.RawLocation to be used elsewhere.
Summary: Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introd...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 09:27 PDT by Vsevolod Vlasov
Modified: 2012-06-09 04:24 PDT (History)
10 users (show)

See Also:


Attachments
Patch (37.16 KB, patch)
2012-05-23 09:34 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (34.19 KB, patch)
2012-05-25 09:04 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (34.19 KB, patch)
2012-06-06 10:07 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-05-23 09:27:14 PDT
WebInspector.RawLocation will eventually become generic raw location independent from concrete domain (Styles, Debugger).
Comment 1 Vsevolod Vlasov 2012-05-23 09:34:45 PDT
Created attachment 143582 [details]
Patch
Comment 2 Pavel Feldman 2012-05-23 11:30:22 PDT
Comment on attachment 143582 [details]
Patch

Lets declare RawLocation as an empty interface instead.
Comment 3 Vsevolod Vlasov 2012-05-25 09:04:41 PDT
Created attachment 144079 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-06-06 10:07:37 PDT
Created attachment 146055 [details]
Patch
Comment 5 Pavel Feldman 2012-06-09 03:47:32 PDT
Comment on attachment 146055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146055&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:218
> +        var rawLocation = /** @type {WebInspector.DebuggerModel.Location} */ location;

There is no need for this cast

> Source/WebCore/inspector/front-end/UISourceCode.js:434
> +WebInspector.RawLocation = function()

Could you remind me why this one does not have lineNumber, columnNumber members?
Comment 6 Vsevolod Vlasov 2012-06-09 04:15:00 PDT
> > Source/WebCore/inspector/front-end/UISourceCode.js:434
> > +WebInspector.RawLocation = function()
> 
> Could you remind me why this one does not have lineNumber, columnNumber members?

There is no way to add a field to compiler interface.
Comment 7 Vsevolod Vlasov 2012-06-09 04:24:05 PDT
Committed r119898: <http://trac.webkit.org/changeset/119898>