Bug 87263 – Web Inspector: add a command to InspectorMemoryAgent for getting process memory break down

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

We need a command that would return us total size of the memory allocated by the inspected process and its breakdown by the components.

[Yury Semikhatsky]

Created attachment 143568 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #1)
> Created an attachment (id=143568) [details]
> Patch

Chromium part of the change: http://codereview.chromium.org/9669039

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Ilya Tikhonovsky]

Comment on attachment 143568 [details]
Patch

lgtm

[Alexei Filippov]

Comment on attachment 143568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143568&action=review

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:322
> +    RefPtr<MemoryBlock> jsHeap = MemoryBlock::create().setName("allcated JS heap").setSize(totalJSHeapSize);

nit: Allocated

[Early Warning System Bot]

Comment on attachment 143568 [details]
Patch

Attachment 143568 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12775246

[Early Warning System Bot]

Comment on attachment 143568 [details]
Patch

Attachment 143568 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12773223

[Build Bot]

Comment on attachment 143568 [details]
Patch

Attachment 143568 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12785080

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 143568 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143568&action=review
> 
> > Source/WebCore/inspector/InspectorMemoryAgent.cpp:322
> > +    RefPtr<MemoryBlock> jsHeap = MemoryBlock::create().setName("allcated JS heap").setSize(totalJSHeapSize);
> 
> nit: Allocated

Fixed.

[Yury Semikhatsky]

Created attachment 143572 [details]
Patch

[Pavel Feldman]

Comment on attachment 143572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143572&action=review

> Source/WebCore/inspector/Inspector.json:95
> +                    { "name": "size", "type": "integer", "description": "Size of the block in bytes" },

You can't report size for some of the nodes. Should this be optional?

> Source/WebCore/inspector/Inspector.json:96
> +                    { "name": "name", "type": "string", "description": "User-friendly name describing the component that allocated this block" },

We don't have a way to localize backend. Should this be key names instead?

[Yury Semikhatsky]

(In reply to comment #11)
> (From update of attachment 143572 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143572&action=review
> 
> > Source/WebCore/inspector/Inspector.json:95
> > +                    { "name": "size", "type": "integer", "description": "Size of the block in bytes" },
> 
> You can't report size for some of the nodes. Should this be optional?
> 
Done.

> > Source/WebCore/inspector/Inspector.json:96
> > +                    { "name": "name", "type": "string", "description": "User-friendly name describing the component that allocated this block" },
> 
> We don't have a way to localize backend. Should this be key names instead?
Done.

[Yury Semikhatsky]

Committed r118357: <http://trac.webkit.org/changeset/118357>

[WebKit Review Bot]

Re-opened since this is blocked by 87387