RESOLVED FIXED 87263
Web Inspector: add a command to InspectorMemoryAgent for getting process memory break down
https://bugs.webkit.org/show_bug.cgi?id=87263
Summary Web Inspector: add a command to InspectorMemoryAgent for getting process memo...
Yury Semikhatsky
Reported 2012-05-23 07:30:08 PDT
We need a command that would return us total size of the memory allocated by the inspected process and its breakdown by the components.
Attachments
Patch (9.64 KB, patch)
2012-05-23 07:38 PDT, Yury Semikhatsky
no flags
Patch (9.65 KB, patch)
2012-05-23 08:11 PDT, Yury Semikhatsky
pfeldman: review+
Yury Semikhatsky
Comment 1 2012-05-23 07:38:37 PDT
Yury Semikhatsky
Comment 2 2012-05-23 07:39:07 PDT
(In reply to comment #1) > Created an attachment (id=143568) [details] > Patch Chromium part of the change: http://codereview.chromium.org/9669039
WebKit Review Bot
Comment 3 2012-05-23 07:41:24 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Ilya Tikhonovsky
Comment 4 2012-05-23 07:52:09 PDT
Comment on attachment 143568 [details] Patch lgtm
Alexei Filippov
Comment 5 2012-05-23 07:53:06 PDT
Comment on attachment 143568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143568&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:322 > + RefPtr<MemoryBlock> jsHeap = MemoryBlock::create().setName("allcated JS heap").setSize(totalJSHeapSize); nit: Allocated
Early Warning System Bot
Comment 6 2012-05-23 07:54:06 PDT
Early Warning System Bot
Comment 7 2012-05-23 08:01:45 PDT
Build Bot
Comment 8 2012-05-23 08:06:44 PDT
Yury Semikhatsky
Comment 9 2012-05-23 08:11:04 PDT
(In reply to comment #5) > (From update of attachment 143568 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143568&action=review > > > Source/WebCore/inspector/InspectorMemoryAgent.cpp:322 > > + RefPtr<MemoryBlock> jsHeap = MemoryBlock::create().setName("allcated JS heap").setSize(totalJSHeapSize); > > nit: Allocated Fixed.
Yury Semikhatsky
Comment 10 2012-05-23 08:11:26 PDT
Pavel Feldman
Comment 11 2012-05-24 04:40:33 PDT
Comment on attachment 143572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143572&action=review > Source/WebCore/inspector/Inspector.json:95 > + { "name": "size", "type": "integer", "description": "Size of the block in bytes" }, You can't report size for some of the nodes. Should this be optional? > Source/WebCore/inspector/Inspector.json:96 > + { "name": "name", "type": "string", "description": "User-friendly name describing the component that allocated this block" }, We don't have a way to localize backend. Should this be key names instead?
Yury Semikhatsky
Comment 12 2012-05-24 05:35:00 PDT
(In reply to comment #11) > (From update of attachment 143572 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143572&action=review > > > Source/WebCore/inspector/Inspector.json:95 > > + { "name": "size", "type": "integer", "description": "Size of the block in bytes" }, > > You can't report size for some of the nodes. Should this be optional? > Done. > > Source/WebCore/inspector/Inspector.json:96 > > + { "name": "name", "type": "string", "description": "User-friendly name describing the component that allocated this block" }, > > We don't have a way to localize backend. Should this be key names instead? Done.
Yury Semikhatsky
Comment 13 2012-05-24 06:01:12 PDT
WebKit Review Bot
Comment 14 2012-05-24 07:23:26 PDT
Re-opened since this is blocked by 87387
Note You need to log in before you can comment on or make changes to this bug.