Bug 87254 - Change EFL debug build name with more detail one
Summary: Change EFL debug build name with more detail one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 05:47 PDT by Gyuyoung Kim
Modified: 2012-05-23 21:38 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.92 KB, patch)
2012-05-23 05:50 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2012-05-23 19:34 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (2.81 KB, patch)
2012-05-23 21:06 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-05-23 05:47:40 PDT
EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name. In addition, though nobody triggers EFL debug buildbot, EFL debug buildbot is registered as trigerable bot.
Comment 1 Gyuyoung Kim 2012-05-23 05:50:29 PDT
Created attachment 143548 [details]
Patch
Comment 2 Gyuyoung Kim 2012-05-23 17:51:22 PDT
CC'ing Ryosuke, Dominik
Comment 3 Ryosuke Niwa 2012-05-23 19:12:49 PDT
Comment on attachment 143548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143548&action=review

> Tools/ChangeLog:10
> +        In addition, though nobody triggers EFL debug buildbot, EFL debug buildbot is registered
> +        as trigerable bot.

This sounds as if you're making it triggerable now. Please revise it something like "In addition, remove efl-linux-debug triggerable since nobody uses it".
Comment 4 Gyuyoung Kim 2012-05-23 19:34:01 PDT
Created attachment 143705 [details]
Patch
Comment 5 Gyuyoung Kim 2012-05-23 19:34:48 PDT
(In reply to comment #3)
> (From update of attachment 143548 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143548&action=review
> 
> > Tools/ChangeLog:10
> > +        In addition, though nobody triggers EFL debug buildbot, EFL debug buildbot is registered
> > +        as trigerable bot.
> 
> This sounds as if you're making it triggerable now. Please revise it something like "In addition, remove efl-linux-debug triggerable since nobody uses it".

Thank you for your review. I fix it.
Comment 6 WebKit Review Bot 2012-05-23 20:49:20 PDT
Comment on attachment 143705 [details]
Patch

Rejecting attachment 143705 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Hunk #1 succeeded at 294 (offset -6 lines).
Hunk #2 FAILED at 319.
Hunk #3 succeeded at 378 (offset -6 lines).
1 out of 3 hunks FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/config.json.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12797051
Comment 7 Gyuyoung Kim 2012-05-23 21:06:55 PDT
Created attachment 143721 [details]
Patch
Comment 8 WebKit Review Bot 2012-05-23 21:38:23 PDT
Comment on attachment 143721 [details]
Patch

Clearing flags on attachment: 143721

Committed r118321: <http://trac.webkit.org/changeset/118321>
Comment 9 WebKit Review Bot 2012-05-23 21:38:28 PDT
All reviewed patches have been landed.  Closing bug.