Bug 87241 - Web Inspector: eliminate getters from HeapSnapshot.js
: Web Inspector: eliminate getters from HeapSnapshot.js
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Ilya Tikhonovsky
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-23 03:08 PDT by Ilya Tikhonovsky
Modified: 2012-05-23 05:07 PDT (History)
11 users (show)

See Also:


Attachments
Patch (55.47 KB, patch)
2012-05-23 03:12 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-23 03:08:01 PDT
getters can't be inlined by engine at the moment.
I found that convertation getters into functions gives us about 600 ms

RESULT heap-snapshot: switch-to-containment-view= 1920 ms

svs

RESULT heap-snapshot: switch-to-containment-view= 1367 ms
Comment 1 Ilya Tikhonovsky 2012-05-23 03:12:04 PDT
Created attachment 143517 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-23 04:50:32 PDT
Comment on attachment 143517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143517&action=review

> Source/WebCore/ChangeLog:7
> +        I found that convertation getters into functions gives us about 600 ms

typo: conversion
Comment 3 Yury Semikhatsky 2012-05-23 04:56:10 PDT
Comment on attachment 143517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143517&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1957
> +            var valueA = typeof valueOrFunctionA !== "function" ? valueOrFunctionA : valueOrFunctionA.call(nodeA);

I guess the properties used for sorting are always functions after this change. If so please remove the typeof condition.
Comment 4 Ilya Tikhonovsky 2012-05-23 05:07:52 PDT
Committed r118162: <http://trac.webkit.org/changeset/118162>