RESOLVED FIXED 87241
Web Inspector: eliminate getters from HeapSnapshot.js 
https://bugs.webkit.org/show_bug.cgi?id=87241
Summary Web Inspector: eliminate getters from HeapSnapshot.js
Ilya Tikhonovsky
Reported 2012-05-23 03:08:01 PDT
getters can't be inlined by engine at the moment. I found that convertation getters into functions gives us about 600 ms RESULT heap-snapshot: switch-to-containment-view= 1920 ms svs RESULT heap-snapshot: switch-to-containment-view= 1367 ms
Attachments
Patch (55.47 KB, patch)
2012-05-23 03:12 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-23 03:12:04 PDT
Created attachment 143517 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-23 04:50:32 PDT
Comment on attachment 143517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143517&action=review > Source/WebCore/ChangeLog:7 > + I found that convertation getters into functions gives us about 600 ms typo: conversion
Yury Semikhatsky
Comment 3 2012-05-23 04:56:10 PDT
Comment on attachment 143517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143517&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:1957 > + var valueA = typeof valueOrFunctionA !== "function" ? valueOrFunctionA : valueOrFunctionA.call(nodeA); I guess the properties used for sorting are always functions after this change. If so please remove the typeof condition.
Ilya Tikhonovsky
Comment 4 2012-05-23 05:07:52 PDT
Committed r118162: <http://trac.webkit.org/changeset/118162>
Note You need to log in before you can comment on or make changes to this bug.