RESOLVED WONTFIX 87232
[chromium] Add isFtpDirectoryListing flag to WebURLResponse 
https://bugs.webkit.org/show_bug.cgi?id=87232
Summary [chromium] Add isFtpDirectoryListing flag to WebURLResponse
jochen
Reported 2012-05-23 01:54:24 PDT
[chromium] Add isFtpDirectoryListing flag to WebURLResponse
Attachments
Patch (7.23 KB, patch)
2012-05-23 01:54 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (7.20 KB, patch)
2012-05-23 02:57 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-05-23 01:54:44 PDT
Created attachment 143501 [details] Patch
WebKit Review Bot
Comment 2 2012-05-23 01:56:11 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
jochen
Comment 3 2012-05-23 01:56:46 PDT
In our WebURLLoader impl, we might replace a raw FTP directory listing with a fancy HTML/js page. Later, we need to detect that the current frame is displaying a ftp directory listing, so we can whitelist it for javascript execution. The heuristic is broken. Instead of fixing the heuristic, just mark the URL response as "ftp directory listing" and whitelist the page depending on this flag. This patch adds the flag on the webkit side
jochen
Comment 4 2012-05-23 02:57:50 PDT
Created attachment 143512 [details] Patch
Adam Barth
Comment 5 2012-05-23 10:53:17 PDT
Comment on attachment 143512 [details] Patch Does WebCore have any use for this data? If only the embedder cares, maybe this should be in ExtraData?
jochen
Comment 6 2012-05-23 10:58:42 PDT
(In reply to comment #5) > (From update of attachment 143512 [details]) > Does WebCore have any use for this data? If only the embedder cares, maybe this should be in ExtraData? I modelled it after the multipart data flag, as the place where we decide that this is a ftp directory listing is the same where we'd decide about multipart data. the extraData is set in content/renderer, whereas the multipart flag is set in webkit/glue it looked more straight forward to add a flag as opposed to refactoring the extra data setting.
Adam Barth
Comment 7 2012-05-23 13:26:37 PDT
We should really be going in the opposite direction of moving state from this objects into ExtraData. If WebCore doesn't have any use for this state, it should remain an implementation detail of the embedder.
Adam Barth
Comment 8 2012-07-27 01:11:18 PDT
Comment on attachment 143512 [details] Patch Cleared review? from attachment 143512 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.