Bug 87208 - [Qt][Mac] http/tests/cookies/js-get-and-set-http-only-cookie.html failing since introduction in r119947
Summary: [Qt][Mac] http/tests/cookies/js-get-and-set-http-only-cookie.html failing sin...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, MakingBotsRed
Depends on: 88760
Blocks: 86067 87008
  Show dependency treegraph
 
Reported: 2012-05-22 21:42 PDT by Stephanie Lewis
Modified: 2014-02-03 03:21 PST (History)
15 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2012-05-22 21:42:13 PDT
http://trac.webkit.org/changeset/118105 added a new test: http/tests/cookies/js-get-and-set-http-only-cookie.php which is failing on Mac WK1 and WK2.

http://build.webkit.org/results/Lion%20Release%20(Tests)/r118111%20(8569)/results.html

--- /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt
+++ /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/http/tests/cookies/js-get-and-set-http-only-cookie-actual.txt
@@ -5,7 +5,7 @@
 
 Check that we can't get or set httpOnly Cookies by JavaScript.
 PASS We can't get httpOnly cookies by JavaScript.
-PASS We can't set httpOnly cookies by JavaScript.
+FAIL We shouldn't set httpOnly cookies by JavaScript.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Radar WebKit Bug Importer 2012-05-22 21:42:28 PDT
<rdar://problem/11512237>
Comment 2 Stephanie Lewis 2012-05-22 22:20:48 PDT
Checked in failing results http://trac.webkit.org/projects/webkit/changeset/118122
Comment 3 Csaba Osztrogonác 2012-05-22 23:47:01 PDT
Same fail on GTK and Qt too.
Comment 4 Csaba Osztrogonác 2012-05-22 23:59:11 PDT
I skipped it on Qt - r118132.
Comment 5 Zan Dobersek 2012-05-23 00:05:47 PDT
It seems this test is also causing various failures (even crashes in GTK builders) in http/tests/cookies/multiple-cookies.html, which is the test that is run after this test.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fcookies%2Fmultiple-cookies.html

I'll skip the test for Gtk.
Comment 6 Stephanie Lewis 2012-05-23 19:09:06 PDT
This test can have side effects.  Skipped in http://trac.webkit.org/changeset/118305
Comment 7 Jason Liu 2012-05-23 20:12:26 PDT
(In reply to comment #5)
> It seems this test is also causing various failures (even crashes in GTK builders) in http/tests/cookies/multiple-cookies.html, which is the test that is run after this test.
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fcookies%2Fmultiple-cookies.html
> 
> I'll skip the test for Gtk.

Do you know why multiple-cookies.html failed?

I don't think my test case can cause this failing.
Comment 8 Zan Dobersek 2012-05-25 08:35:00 PDT
(In reply to comment #7)
> (In reply to comment #5)
> > It seems this test is also causing various failures (even crashes in GTK builders) in http/tests/cookies/multiple-cookies.html, which is the test that is run after this test.
> > 
> > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fcookies%2Fmultiple-cookies.html
> > 
> > I'll skip the test for Gtk.
> 
> Do you know why multiple-cookies.html failed?
> 
> I don't think my test case can cause this failing.

The stderr output of the crash was:
'Creating pipes for GWakeup: Too many open files'

This perhaps signals a platform-specific problem, i.e. a bug in either the libsoup HTTP backend or libsoup itself.
Comment 9 Jason Liu 2012-06-05 05:28:16 PDT
The failure on mac is because of an actual bug in cookie jar.
Comment 10 jochen 2012-06-05 05:31:58 PDT
To be more precise in WebCore/platform/mac/CookieJar.mm, it is not checked that a new cookie wouldn't override an existing httpOnly cookie.
Comment 11 Chris Dumez 2012-06-11 00:22:10 PDT
I will work on a fix for the SOUP-specific code in Bug 88760. This looks like a valid problem as we allow setting/overwriting httpOnly cookies from JavaScript.
Comment 12 Csaba Osztrogonác 2012-06-11 02:02:14 PDT
Skipped on Qt by http://trac.webkit.org/changeset/119964/trunk/LayoutTests/platform/qt/Skipped

Please unskip it with the proper fix.
Comment 13 Jessie Berlin 2012-08-31 10:17:19 PDT
This test was removed in http://trac.webkit.org/changeset/118166 and reintroduced as http/tests/cookies/js-get-and-set-http-only-cookie.html, which does not appear to be suffering from the same problems.

I am going to fix up the Skipped lists.
Comment 14 Jessie Berlin 2012-08-31 10:19:58 PDT
Actually, it looks like the Qt Skipped list entry was for the .html version introduced in http://trac.webkit.org/changeset/119947. Updating the title to reflect that.
Comment 15 Alexey Proskuryakov 2012-11-06 13:21:28 PST
Actually, this still fails on Mac, <rdar://problem/12427027>.
Comment 16 Ádám Kallai 2013-02-14 08:15:14 PST
I checked this test but it still fails on Qt.
Comment 17 Jocelyn Turcotte 2014-02-03 03:21:00 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.