RESOLVED WONTFIX 87207
[V8] Pass Isolate to v8::Null() in custom bindings (Part 1) 
https://bugs.webkit.org/show_bug.cgi?id=87207
Summary [V8] Pass Isolate to v8::Null() in custom bindings (Part 1)
Kentaro Hara
Reported 2012-05-22 21:33:57 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8::Null() in custom bindings.
Attachments
Patch (25.09 KB, patch)
2012-05-22 21:36 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (556.72 KB, application/zip)
2012-05-22 23:05 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-22 21:36:34 PDT
Created attachment 143455 [details] Patch
WebKit Review Bot
Comment 2 2012-05-22 23:05:25 PDT
Comment on attachment 143455 [details] Patch Attachment 143455 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12769114 New failing tests: perf/object-keys.html
WebKit Review Bot
Comment 3 2012-05-22 23:05:29 PDT
Created attachment 143467 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Kentaro Hara
Comment 4 2012-05-22 23:09:00 PDT
Comment on attachment 143455 [details] Patch > New failing tests: > perf/object-keys.html It passes on my machine. cq+ again.
WebKit Review Bot
Comment 5 2012-05-23 00:05:32 PDT
Comment on attachment 143455 [details] Patch Clearing flags on attachment: 143455 Committed r118133: <http://trac.webkit.org/changeset/118133>
WebKit Review Bot
Comment 6 2012-05-23 00:05:42 PDT
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 7 2012-05-23 17:10:34 PDT
Reverted r118133 for reason: some LayoutTests crash since the patch passes a NULL to Null(isolate) Committed r118273: <http://trac.webkit.org/changeset/118273>
Note You need to log in before you can comment on or make changes to this bug.