Bug 87207 - [V8] Pass Isolate to v8::Null() in custom bindings (Part 1)
Summary: [V8] Pass Isolate to v8::Null() in custom bindings (Part 1)
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency treegraph
 
Reported: 2012-05-22 21:33 PDT by Kentaro Hara
Modified: 2012-05-23 17:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (25.09 KB, patch)
2012-05-22 21:36 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (556.72 KB, application/zip)
2012-05-22 23:05 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-22 21:33:57 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8::Null() in custom bindings.
Comment 1 Kentaro Hara 2012-05-22 21:36:34 PDT
Created attachment 143455 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-22 23:05:25 PDT
Comment on attachment 143455 [details]
Patch

Attachment 143455 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12769114

New failing tests:
perf/object-keys.html
Comment 3 WebKit Review Bot 2012-05-22 23:05:29 PDT
Created attachment 143467 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Kentaro Hara 2012-05-22 23:09:00 PDT
Comment on attachment 143455 [details]
Patch

> New failing tests:
> perf/object-keys.html

It passes on my machine. cq+ again.
Comment 5 WebKit Review Bot 2012-05-23 00:05:32 PDT
Comment on attachment 143455 [details]
Patch

Clearing flags on attachment: 143455

Committed r118133: <http://trac.webkit.org/changeset/118133>
Comment 6 WebKit Review Bot 2012-05-23 00:05:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Kentaro Hara 2012-05-23 17:10:34 PDT
Reverted r118133 for reason:

some LayoutTests crash since the patch passes a NULL to Null(isolate)

Committed r118273: <http://trac.webkit.org/changeset/118273>