You need to
before you can comment on or make changes to this bug.
Otherwise OSR exit may decided to set them to Undefined.
Currently a variable may appear to be dead at a basic block boundary even though it is captured. As a hack, we can peek at the first node of the successor block(s) and check what variables are captured at that node's code origin. But that's just disgusting and wrong.
The right solution is to change how captured variables are flushed. Currently we flush SetLocals by planting a Flush node right after them:
But we could instead have a flush right before each SetLocal:
As well as a Flush for all captured variables at the return site. That will effectively keep variables alive through the whole span of code in which they are captured.
Created an attachment (id=144458) [details]
work in progress
Created an attachment (id=144464) [details]
it's starting to work
Created an attachment (id=144616) [details]
Still making sure that I've dotted all of my t's.
Created an attachment (id=144629) [details]
It's starting to pass tests.
Created an attachment (id=144638) [details]
Landed in http://trac.webkit.org/changeset/118858
Just for your information, I've got a build warning on my laptop as below. :-)