Bug 87204 - [V8] Pass Isolate to v8::Null() in bindings/v8/*.{h,cpp}
Summary: [V8] Pass Isolate to v8::Null() in bindings/v8/*.{h,cpp}
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency treegraph
 
Reported: 2012-05-22 21:22 PDT by Kentaro Hara
Modified: 2012-05-23 17:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.98 KB, patch)
2012-05-22 21:23 PDT, Kentaro Hara
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-04 (598.20 KB, application/zip)
2012-05-22 23:10 PDT, WebKit Review Bot
no flags Details
patch for landing (5.51 KB, patch)
2012-05-22 23:39 PDT, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-03 (553.26 KB, application/zip)
2012-05-23 02:14 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-22 21:22:03 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8::Null() in bindings/v8/*.{h,cpp}.
Comment 1 Kentaro Hara 2012-05-22 21:23:37 PDT
Created attachment 143451 [details]
Patch
Comment 2 Build Bot 2012-05-22 21:46:20 PDT
Comment on attachment 143451 [details]
Patch

Attachment 143451 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12767146
Comment 3 Adam Barth 2012-05-22 22:49:36 PDT
Comment on attachment 143451 [details]
Patch

I wonder why the win bot went red.  None of this code should be linked into win.  Please watch the bot when landing to make sure this patch doesn't cause a problem.
Comment 4 Adam Barth 2012-05-22 23:03:01 PDT
WebKitSupportLibrary.zip is out-of-date.

^^ The win-ews error doesn't look like your fault.
Comment 5 Kentaro Hara 2012-05-22 23:04:14 PDT
(In reply to comment #4)
> WebKitSupportLibrary.zip is out-of-date.
> 
> ^^ The win-ews error doesn't look like your fault.

Yeah, I hope commit-queue will land the patch.
Comment 6 WebKit Review Bot 2012-05-22 23:10:02 PDT
Comment on attachment 143451 [details]
Patch

Attachment 143451 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12770115

New failing tests:
fast/dom/StyleSheet/css-medialist-item.html
webintents/web-intents-api.html
storage/indexeddb/keypath-edges.html
fast/dom/HTMLElement/class-list.html
storage/indexeddb/database-basics.html
fast/dom/HTMLElement/class-list-quirks.html
storage/indexeddb/objectstore-basics-workers.html
storage/indexeddb/objectstore-basics.html
svg/css/svg-attribute-parser-mode.html
storage/indexeddb/index-basics.html
fast/dom/HTMLOutputElement/dom-settable-token-list.html
storage/indexeddb/index-basics-workers.html
Comment 7 WebKit Review Bot 2012-05-22 23:10:06 PDT
Created attachment 143469 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 Kentaro Hara 2012-05-22 23:39:38 PDT
Created attachment 143475 [details]
patch for landing
Comment 9 WebKit Review Bot 2012-05-23 02:14:28 PDT
Comment on attachment 143475 [details]
patch for landing

Rejecting attachment 143475 [details] from commit-queue.

New failing tests:
webintents/web-intents-api.html
storage/indexeddb/keypath-edges.html
storage/indexeddb/objectstore-basics-workers.html
storage/indexeddb/objectstore-basics.html
storage/indexeddb/index-basics.html
storage/indexeddb/index-basics-workers.html
Full output: http://queues.webkit.org/results/12767211
Comment 10 WebKit Review Bot 2012-05-23 02:14:33 PDT
Created attachment 143506 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick