Bug 87202 - [V8] Pass Isolate to v8::Null() in CodeGeneratorV8.pm
Summary: [V8] Pass Isolate to v8::Null() in CodeGeneratorV8.pm
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency tree / graph
 
Reported: 2012-05-22 21:11 PDT by Kentaro Hara
Modified: 2012-05-23 17:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.30 KB, patch)
2012-05-22 21:13 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-22 21:11:48 PDT 
The objective is to pass Isolate around in V8 bindings. We pass Isolate to v8::Null() in CodeGeneratorV8.pm.
Comment 1 Kentaro Hara 2012-05-22 21:13:14 PDT 
Created attachment 143448 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-22 23:35:28 PDT 
Comment on attachment 143448 [details]
Patch

Clearing flags on attachment: 143448

Committed r118129: <http://trac.webkit.org/changeset/118129>
Comment 3 WebKit Review Bot 2012-05-22 23:35:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Kentaro Hara 2012-05-23 17:11:28 PDT 
Reverted r118129 for reason:

some LayoutTests crash since the patch passes a NULL to Null(isolate)

Committed r118274: <http://trac.webkit.org/changeset/118274>