Bug 87193 - [V8][Performance] Pass Isolate to v8::Null() in V8Node::toV8()
Summary: [V8][Performance] Pass Isolate to v8::Null() in V8Node::toV8()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 84074
  Show dependency treegraph
Reported: 2012-05-22 18:30 PDT by Kentaro Hara
Modified: 2012-05-23 17:16 PDT (History)
6 users (show)

See Also:

Patch (12.10 KB, patch)
2012-05-22 18:37 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (13.31 KB, patch)
2012-05-22 19:08 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-22 18:30:58 PDT
Currently v8::Null() looks up Isolate, which is a bottleneck of V8Node::toV8() for undefined Nodes. We can remove the Isolate look-up by passing Isolate to v8::Null(), like v8::Null(isolate). This will improve the performance of Bindings/undefined-first-child.html, which tests the performance for accessing a Node object that is not yet defined.
Comment 1 Kentaro Hara 2012-05-22 18:37:21 PDT
Created attachment 143430 [details]
Comment 2 Kentaro Hara 2012-05-22 19:08:56 PDT
Created attachment 143435 [details]
Comment 3 WebKit Review Bot 2012-05-22 21:55:45 PDT
Comment on attachment 143435 [details]

Clearing flags on attachment: 143435

Committed r118120: <http://trac.webkit.org/changeset/118120>
Comment 4 WebKit Review Bot 2012-05-22 21:55:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Kentaro Hara 2012-05-23 17:12:25 PDT
Reverted r118120 for reason:

some LayoutTests crash since the patch passes a NULL to Null(isolate)

Committed r118275: <http://trac.webkit.org/changeset/118275>