Bug 87179 - DFG CSE should eliminate redundant WeakJSConstants
Summary: DFG CSE should eliminate redundant WeakJSConstants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 16:17 PDT by Filip Pizlo
Modified: 2012-05-25 16:01 PDT (History)
0 users

See Also:

Attachments
the patch (2.43 KB, patch)
2012-05-22 16:25 PDT, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-05-22 16:17:04 PDT 
This will allow it to eliminate more redundant CheckStructures.

This is only going to be a tiny win, since the bytecode parser usually eliminates these (it only misses those cases that are later revealed by CFG simplification). But it's an easy change, so it's worth it.
Comment 1 Filip Pizlo 2012-05-22 16:25:26 PDT 
Created attachment 143393 [details]
the patch
Comment 2 Filip Pizlo 2012-05-23 00:39:30 PDT 
Landed in http://trac.webkit.org/changeset/118141
Comment 3 Filip Pizlo 2012-05-25 16:01:18 PDT 
Merged in http://trac.webkit.org/changeset/118582