Bug 87176 - [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
Summary: [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency treegraph
 
Reported: 2012-05-22 15:57 PDT by Xianzhu Wang
Modified: 2012-05-22 17:20 PDT (History)
4 users (show)

See Also:


Attachments
patch (3.46 KB, patch)
2012-05-22 16:19 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-05-22 15:57:17 PDT
For now both DumpRenderTree.gypi and DumpRenderTree.gyp contain conditions about DumpRenderTree sources. I think we should move all conditions into DumpRenderTree.gyp. Some conditions in DumpRenderTree.gypi (e.g. the ones about win and mac) are also redundant and should be removed.
Comment 1 Xianzhu Wang 2012-05-22 16:19:07 PDT
Created attachment 143391 [details]
patch
Comment 2 WebKit Review Bot 2012-05-22 17:20:22 PDT
Comment on attachment 143391 [details]
patch

Clearing flags on attachment: 143391

Committed r118085: <http://trac.webkit.org/changeset/118085>
Comment 3 WebKit Review Bot 2012-05-22 17:20:27 PDT
All reviewed patches have been landed.  Closing bug.