Bug 87169 – Move some CSS regions properties to CSSParser::isValidKeywordPropertyAndValue.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Alexis Menard (darktears)]

Move some CSS regions properties to CSSParser::isValidKeywordPropertyAndValue.

[Alexis Menard (darktears)]

Created attachment 143365 [details]
Patch

[Tony Chang]

Comment on attachment 143365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143365&action=review

OK

> Source/WebCore/css/CSSParser.cpp:588
> +    case CSSPropertyWebkitColumnBreakBefore:
> +    case CSSPropertyWebkitRegionBreakAfter:
> +    case CSSPropertyWebkitRegionBreakBefore:
> +        if (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight)
> +            return ((propertyId == CSSPropertyWebkitRegionBreakAfter) || (propertyId == CSSPropertyWebkitRegionBreakBefore)) ? parserContext.isCSSRegionsEnabled : true;

Should we split the region properties into a separate part of the switch statement?  It would avoid the extra check for the non-region properties.

[Alexis Menard (darktears)]

(In reply to comment #2)
> (From update of attachment 143365 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143365&action=review
> 
> OK
> 
> > Source/WebCore/css/CSSParser.cpp:588
> > +    case CSSPropertyWebkitColumnBreakBefore:
> > +    case CSSPropertyWebkitRegionBreakAfter:
> > +    case CSSPropertyWebkitRegionBreakBefore:
> > +        if (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight)
> > +            return ((propertyId == CSSPropertyWebkitRegionBreakAfter) || (propertyId == CSSPropertyWebkitRegionBreakBefore)) ? parserContext.isCSSRegionsEnabled : true;
> 
> Should we split the region properties into a separate part of the switch statement?  It would avoid the extra check for the non-region properties.

Ok make sense.

[Alexis Menard (darktears)]

Created attachment 143371 [details]
Patch for landing

[Alexis Menard (darktears)]

Created attachment 143372 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143372 [details]
Patch for landing

Clearing flags on attachment: 143372

Committed r118082: <http://trac.webkit.org/changeset/118082>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.