Bug 87162 – WTR needs an implementation of setAutomaticLinkDetectionEnabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jessie Berlin]

It was added in http://trac.webkit.org/changeset/117590 for DRT, but not for WTR.

[Radar WebKit Bug Importer]

<rdar://problem/11508445>

[Ryosuke Niwa]

I don't think this is a regression.

[Martin Robinson]

*** Bug 99069 has been marked as a duplicate of this bug. ***

[Jonathan Bedard]

Note that while investigating, https://bugs.webkit.org/show_bug.cgi?id=160713 was uncovered.  Note that despite some of the comments in various configuration files, the two tests which call setAutomaticLinkDetectionEnabled and are still failing are doing so through a different mechanism than the ones corrected here.

[Jonathan Bedard]

Created attachment 285683 [details]
Patch

[Jonathan Bedard]

Created attachment 285752 [details]
Patch

[Jonathan Bedard]

Note that it is only Mac that implements the underlying functionality setAutomaticLinkDetectionEnabled is designed to test.

[Darin Adler]

Comment on attachment 285752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285752&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:310
> +    if (static_cast<bool>(enabled) == TextChecker::state().isAutomaticLinkDetectionEnabled)

static_cast<bool>(enabled) is wrong here; just "enabled" will do

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:315
> +    fputs("Automatic link detection undefined for this platform\n", stderr);

It’s not appropriate to write directly to stderr from this class.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:52
> +    WK_EXPORT void WKBundleSetAutomaticLinkDetectionEnabled(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, bool enabled);

This should not be indented. Please match the lines above and below this.

[Jonathan Bedard]

Created attachment 286605 [details]
Patch

[Jonathan Bedard]

Comment on attachment 286605 [details]
Patch

Requesting commit queue.  The gtk-wk2 failure is unrelated to this patch.

[WebKit Commit Bot]

Comment on attachment 286605 [details]
Patch

Clearing flags on attachment: 286605

Committed r205094: <http://trac.webkit.org/changeset/205094>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.