RESOLVED WORKSFORME 87160
Layout Tests platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html and visibility-simple-webgl-layer.html are failing 
https://bugs.webkit.org/show_bug.cgi?id=87160
Summary Layout Tests platform/chromium/virtual/threaded/compositing/visibility/visibi...
Joshua Bell
Reported 2012-05-22 13:17:35 PDT
Tests: platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html Platforms: Primarily Windows: Vista, Win, Win (dbg), Win7 Crashes also seen on Mac10.6 and Linux, but with much lower frequency Flakiness Dashboard links: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Fvirtual%2Fthreaded%2Fcompositing%2Fvisibility%2Fvisibility-simple-canvas2d-layer.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Fvirtual%2Fthreaded%2Fcompositing%2Fvisibility%2Fvisibility-simple-webgl-layer.html The failures are intermittent crashes. The failure frequency increased significantly around WK r117831 but given the frequency of crashes (10-20% of runs) the change likely predates that by several revisions. Sample backtraces are not terribly useful: 18:21:40.847 2640 Backtrace: 18:21:40.847 2640 (No symbol) [0x00000000] 18:21:40.847 2640 (No symbol) [0x10132078] .... 18:21:40.847 2640 (No symbol) [0x00DC8202] 18:21:40.847 2640 18:21:40.863 2640 worker/3 killing driver 22:56:14.139 3242 worker/1 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html crashed, stack trace: 22:56:14.139 3242 base::debug::StackTrace::StackTrace() [0x66bf6e] 22:56:14.139 3242 base::(anonymous namespace)::StackDumpSignalHandler() [0x658559] 22:56:14.139 3242 0x7f5d3b9d4af0 22:56:14.140 3242 worker/1 killing driver 22:56:14.141 3218 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html -> unexpected crash 01:38:44.571 1636 worker/1 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html crashed, stack trace: 01:38:44.571 1636 [4036:8528:3170562:FATAL:gl_context.cc(39)] Check failed: IsCurrent(NULL). 01:38:44.571 1636 Backtrace: 01:38:44.571 1636 base::SharedMemory::CreateAnonymous [0x00D1DE31+2159353] 01:38:44.571 1636 base::SharedMemory::CreateAnonymous [0x00BD267E+801606] 01:38:44.571 1636 gfx::GLContext::GetCurrent [0x0B3D61DA+146931] 01:38:44.571 1636 gfx::GLContext::GetCurrent [0x0B3D64B1+147658] 01:38:44.571 1636 gpu::gles2::ContextGroup::feature_info [0x0B135230+567508] 01:38:44.571 1636 (No symbol) [0x005641DB] 01:38:44.571 1636 (No symbol) [0x00562C57] 01:38:44.571 1636 (No symbol) [0x00565390] 01:38:44.571 1636 (No symbol) [0x004B7B64] 01:38:44.571 1636 WebKit::WebURLRequest::hasUserGesture [0x01AA9B9A+1042191] ... 01:38:44.633 1636 WebKit::WebURLRequest::hasUserGesture [0x0305CC65+23795674] 01:38:44.633 1636 std::_Init_locks::operator= [0x039A3AB8+1137864] 01:38:44.633 1636 v8::Locker::StopPreemption [0x012F7237+769815] ... 01:38:44.633 1636 v8::Locker::StopPreemption [0x014FA6DD+2880445] 01:38:44.633 1636 01:38:44.633 1636 Backtrace: 01:38:44.633 1636 base::SharedMemory::CreateAnonymous [0x00D04B71+2056249] 01:38:44.633 1636 base::SharedMemory::CreateAnonymous [0x00BD2A4D+802581] 01:38:44.633 1636 gfx::GLContext::GetCurrent [0x0B3D61DA+146931] 01:38:44.633 1636 gfx::GLContext::GetCurrent [0x0B3D64B1+147658] 01:38:44.633 1636 gpu::gles2::ContextGroup::feature_info [0x0B135230+567508] 01:38:44.633 1636 (No symbol) [0x005641DB] 01:38:44.633 1636 (No symbol) [0x00562C57] 01:38:44.633 1636 (No symbol) [0x00565390] 01:38:44.633 1636 (No symbol) [0x004B7B64] 01:38:44.633 1636 WebKit::WebURLRequest::hasUserGesture [0x01AA9B9A+1042191] ... 01:38:44.633 1636 WebKit::WebURLRequest::hasUserGesture [0x0305CC65+23795674] 01:38:44.633 1636 std::_Init_locks::operator= [0x039A3AB8+1137864] 01:38:44.633 1636 v8::Locker::StopPreemption [0x012F7237+769815] ... 01:38:44.633 1636 v8::Locker::StopPreemption [0x014FA6DD+2880445] 01:38:44.633 1636 (No symbol) [0x3D30A336] ... 01:38:44.633 1636 (No symbol) [0x3D312C6A] 01:38:44.633 1636 v8::Locker::StopPreemption [0x0129979C+386172] 01:38:44.633 1636 v8::Locker::StopPreemption [0x01299524+385540] 01:38:44.633 1636 v8::Function::Call [0x012207F4+484] 01:38:44.633 1636 WebKit::WebURLRequest::hasUserGesture [0x02616CEC+13023329] ...
Attachments
Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-05-22 13:19:42 PDT
The "tests" list should be: platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html
vollick
Comment 2 2012-05-23 08:13:54 PDT
The crashes have to do with gl contexts. Nat, James, do you know who might be a good person to look at this?
Joshua Bell
Comment 3 2012-05-24 11:57:25 PDT
FYI, another linux stack. Will widen the suppression. 11:30:27.718 10319 worker/22 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html crashed, stack trace: 11:30:27.718 10319 [13277:13277:5347629969420:FATAL:gl_context.cc(39)] Check failed: IsCurrent(NULL). 11:30:27.718 10319 Backtrace: 11:30:27.718 10319 base::debug::StackTrace::StackTrace() [0x875702] 11:30:27.718 10319 logging::LogMessage::~LogMessage() [0x808e93] 11:30:27.718 10319 gfx::GLContext::GetExtensions() [0xf12f80] 11:30:27.718 10319 gfx::GLContext::HasExtension() [0xf1307f] 11:30:27.718 10319 gpu::gles2::GLES2DecoderImpl::Initialize() [0x1fe56f0] 11:30:27.718 10319 webkit::gpu::GLInProcessContext::Initialize() [0x1fa8fb3] 11:30:27.718 10319 webkit::gpu::GLInProcessContext::CreateOffscreenContext() [0x1fa8016] 11:30:27.718 10319 webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl::Initialize() [0x1fa9b91] 11:30:27.718 10319 TestWebKitPlatformSupport::createOffscreenGraphicsContext3D() [0x676666] 11:30:27.718 10319 WebCore::GraphicsContext3D::create() [0x513388] 11:30:27.718 10319 WebCore::WebGLRenderingContext::create() [0x1027065] 11:30:27.718 10319 WebCore::HTMLCanvasElement::getContext() [0xf8c1ab] 11:30:27.718 10319 WebCore::V8HTMLCanvasElement::getContextCallback() [0x27ee00b] 11:30:27.719 10319 v8::internal::HandleApiCallHelper<>() [0xb45848] 11:30:27.719 10319 v8::internal::Builtin_Impl_HandleApiCall() [0xb407bc] 11:30:27.719 10319 v8::internal::Builtin_HandleApiCall() [0xb4078d] 11:30:27.719 10319 0x1423c480618e 11:30:27.719 10319
James Robinson
Comment 4 2012-05-29 21:10:50 PDT
It looks like WebGraphicsContext3DInProcessCommandBufferImpl is thinking that create...() makes the context current, but it doesn't. I guess I can look into it.
Ryosuke Niwa
Comment 5 2012-06-09 13:52:50 PDT
No longer crashes.
Note You need to log in before you can comment on or make changes to this bug.