Bug 87153 - [chromium] Forcibly sync running animations in the waiting state when synchronized start times are needed.
Summary: [chromium] Forcibly sync running animations in the waiting state when synchro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: vollick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 11:40 PDT by vollick
Modified: 2012-05-24 07:13 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.93 KB, patch)
2012-05-22 11:42 PDT, vollick
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vollick 2012-05-22 11:40:14 PDT
Currently, when we force a sync of the animations, we blindly copy them to the impl thread. This is a problem if the main thread is waiting for a synchronized start time and the animation has already started on the main thread. In this case, we would copy the running animation over to the impl thread, where it would happily tick, but would never send an 'animation started' notification to the main thread. If the main thread animation requires this notification, we must copy the animation over in a 'waiting' state.
Comment 1 vollick 2012-05-22 11:42:03 PDT
Created attachment 143336 [details]
Patch
Comment 2 James Robinson 2012-05-23 15:27:32 PDT
Comment on attachment 143336 [details]
Patch

Looks good.
Comment 3 WebKit Review Bot 2012-05-24 07:13:03 PDT
Comment on attachment 143336 [details]
Patch

Clearing flags on attachment: 143336

Committed r118364: <http://trac.webkit.org/changeset/118364>
Comment 4 WebKit Review Bot 2012-05-24 07:13:08 PDT
All reviewed patches have been landed.  Closing bug.