Bug 87147 – add back the ability to disable flexbox

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tony Chang]

We need to be able to disable the new flexbox as the spec settles down.

The easiest way is to add an ENABLE flag that disables just the css parsing of display: -webkit-flex.  We should keep it enabled on trunk so we can keep running the tests on the bots.

[Ojan Vafai]

Created attachment 143626 [details]
Patch

[Tony Chang]

Comment on attachment 143626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143626&action=review

> Source/WebKit/chromium/features.gypi:135
> +      'enable_css3_flexbox%': 1,

I would just hardcode ENABLE_CSS3_FLEXBOX=1 in the feature_defines variable.

[Ojan Vafai]

Created attachment 143640 [details]
Patch

[WebKit Review Bot]

Comment on attachment 143640 [details]
Patch

Rejecting attachment 143640 [details] from commit-queue.

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/css/display-no-show-hide.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
editing/deleting/delete-select-all-002.html
fast/css-grid-layout/grid-disabled-by-default.html
Full output: http://queues.webkit.org/results/12773359

[WebKit Review Bot]

Created attachment 143669 [details]
Archive of layout-test-results from ec2-cq-01

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[WebKit Review Bot]

Comment on attachment 143640 [details]
Patch

Attachment 143640 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12775372

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/css/display-no-show-hide.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
editing/deleting/delete-select-all-002.html
fast/css-grid-layout/grid-disabled-by-default.html

[WebKit Review Bot]

Created attachment 143677 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ojan Vafai]

Created attachment 143679 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143679 [details]
Patch for landing

Clearing flags on attachment: 143679

Committed r118304: <http://trac.webkit.org/changeset/118304>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Raphael Kubo da Costa (:rakuco)]

Committed the analog CMake change in <http://trac.webkit.org/changeset/118313>, please don't forget CMake in similar future patches.

[Csaba Osztrogonác]

(In reply to comment #9)
> (From update of attachment 143679 [details])
> Clearing flags on attachment: 143679
> 
> Committed r118304: <http://trac.webkit.org/changeset/118304>

Qt fix after this change - http://trac.webkit.org/changeset/118332

[Tony Chang]

*** Bug 87397 has been marked as a duplicate of this bug. ***

[Philippe Normand]

(In reply to comment #9)
> (From update of attachment 143679 [details])
> Clearing flags on attachment: 143679
> 
> Committed r118304: <http://trac.webkit.org/changeset/118304>

GTK was forgotten as well... working on a patch...

[Ojan Vafai]

Ugh. Sorry for all the breakages. I was just undoing the patch that removed the previously existing define. 

We have too many build systems. :(