REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots Link to change: http://trac.webkit.org/changeset/117815 Link to example of failure: http://build.webkit.org/results/Lion%20Release%20(Tests)/r117988%20(8548)/results.html 117815 purported to be only about enabling a feature on Chromium, so it seems odd it could have caused this. But it never failed up to and including 117813, then has been failing started in 117815. 117814 cannot possibly have affected Mac as it only touched a Chromium.cpp file - (http://trac.webkit.org/changeset/117814) - so 117815 must be it.
Skipped in http://trac.webkit.org/changeset/118003 Please unskip after you have resolved the regression.
It's possible, but it would have come from an earlier change in teh subpixel change I think.
(In reply to comment #2) > It's possible, but it would have come from an earlier change in teh subpixel change I think. I'm having a hard time grok'ing this sentence. All I know is that from 117813 back the test was fine.
(In reply to comment #3) > (In reply to comment #2) > > It's possible, but it would have come from an earlier change in teh subpixel change I think. > > I'm having a hard time grok'ing this sentence. > > All I know is that from 117813 back the test was fine. The numbers being returned are correct, it looks like a test issue.
Created attachment 143337 [details] Patch
Comment on attachment 143337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) I don'dt quite understnad thsi complicated check.
(In reply to comment #6) > (From update of attachment 143337 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > > > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) > > I don'dt quite understnad thsi complicated check. That's why I added the comment...
Comment on attachment 143337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review Please also unskip this test on Mac before landing. > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) This is ugly to have to do, but okay.
Even though Levi r+'ed, please unskip the test as well.
(In reply to comment #9) > Even though Levi r+'ed, please unskip the test as well. Will do!
(In reply to comment #8) > (From update of attachment 143337 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > > Please also unskip this test on Mac before landing. ^^^ :)
Committed r118013: <http://trac.webkit.org/changeset/118013>
*** Bug 87099 has been marked as a duplicate of this bug. ***