Bug 87141 - !HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Android build
Summary: !HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 10:05 PDT by Adam Barth
Modified: 2012-05-22 11:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2012-05-22 10:07 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2012-05-22 10:08 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2012-05-22 10:19 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-05-22 10:05:54 PDT 
!HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Android build
Comment 1 Adam Barth 2012-05-22 10:07:43 PDT 
Created attachment 143319 [details]
Patch
Comment 2 Adam Barth 2012-05-22 10:08:26 PDT 
Created attachment 143320 [details]
Patch
Comment 3 Early Warning System Bot 2012-05-22 10:15:31 PDT 
Comment on attachment 143320 [details]
Patch

Attachment 143320 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12762086
Comment 4 Adam Barth 2012-05-22 10:19:31 PDT 
Created attachment 143324 [details]
Patch
Comment 5 Peter Beverloo 2012-05-22 10:37:11 PDT 
LGTM, thanks! I confirmed that this patch fixes the remaining linking error in a Chromium-Android build.
Comment 6 Eric Seidel (no email) 2012-05-22 11:28:39 PDT 
Comment on attachment 143324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143324&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:1226
> +#if HAVE(ACCESSIBILITY)

I'm surprised the rest of this file isn't wrapped in !ACCSSIBILITY
Comment 7 Adam Barth 2012-05-22 11:31:22 PDT 
(In reply to comment #6)
> (From update of attachment 143324 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143324&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:1226
> > +#if HAVE(ACCESSIBILITY)
> 
> I'm surprised the rest of this file isn't wrapped in !ACCSSIBILITY

Me too!  I tried that originally, but that didn't link on Qt.  It might be worth studying why, but I don't have a Qt build to play with so I went with the path of least resistance.
Comment 8 WebKit Review Bot 2012-05-22 11:50:01 PDT 
Comment on attachment 143324 [details]
Patch

Clearing flags on attachment: 143324

Committed r118012: <http://trac.webkit.org/changeset/118012>
Comment 9 WebKit Review Bot 2012-05-22 11:50:06 PDT 
All reviewed patches have been landed.  Closing bug.