Bug 87136 - REGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests failing on Mac bots.
Summary: REGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests fai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: LayoutTestFailure, Regression
: 75507 (view as bug list)
Depends on: 86877
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-22 09:02 PDT by Brady Eidson
Modified: 2012-05-23 13:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.04 KB, patch)
2012-05-22 19:43 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Rebaselined patch (5.13 KB, patch)
2012-05-23 11:02 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-05-22 09:02:31 PDT 
REGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests failing on Mac bots.

fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html

Due to http://trac.webkit.org/changeset/117918

Example of failures:
http://build.webkit.org/results/Lion%20Release%20(Tests)/r117918%20(8526)/results.html
Comment 1 Brady Eidson 2012-05-22 09:10:21 PDT 
Skipped in http://trac.webkit.org/changeset/117982

Please unskip after you fix the regression.
Comment 2 Kenneth Russell 2012-05-22 09:26:00 PDT 
Thanks for filing this and sorry about the regression. I suspect that the error is related to the setup of the WebGL context's back buffer rather than anything specifically related to this test. Possibly related to Bug 81284. Will investigate.
Comment 3 Kenneth Russell 2012-05-22 19:43:13 PDT 
Created attachment 143438 [details]
Patch
Comment 4 Kenneth Russell 2012-05-22 19:45:17 PDT 
This also fixes Bug 75507.
Comment 5 Kenneth Russell 2012-05-23 11:02:28 PDT 
Created attachment 143597 [details]
Rebaselined patch
Comment 6 Stephen White 2012-05-23 11:06:05 PDT 
Comment on attachment 143597 [details]
Rebaselined patch

Looks good, as long as the bots like it.  r=me
Comment 7 WebKit Review Bot 2012-05-23 12:21:20 PDT 
Comment on attachment 143597 [details]
Rebaselined patch

Clearing flags on attachment: 143597

Committed r118225: <http://trac.webkit.org/changeset/118225>
Comment 8 WebKit Review Bot 2012-05-23 12:21:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Kenneth Russell 2012-05-23 13:20:39 PDT 
*** Bug 75507 has been marked as a duplicate of this bug. ***