Bug 87131 - Web Inspector: HeapSnapshot: speedUp buildAggregates
Summary: Web Inspector: HeapSnapshot: speedUp buildAggregates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 07:34 PDT by Ilya Tikhonovsky
Modified: 2012-05-22 07:47 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.08 KB, patch)
2012-05-22 07:38 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-22 07:34:23 PDT 
engine specific optimization changes. V8 can't inline getters and optimize for(i in object) loops.
I can do this because JSC doesn't have support for HeapProfiler.

RESULT heap-snapshot: _buildAggregates= 1509 ms
RESULT heap-snapshot: _calculateClassesRetainedSize= 1886 ms

vs

RESULT heap-snapshot: _buildAggregates= 665 ms
RESULT heap-snapshot: _calculateClassesRetainedSize= 1293 ms
Comment 1 Ilya Tikhonovsky 2012-05-22 07:38:57 PDT 
Created attachment 143298 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-05-22 07:47:53 PDT 
Committed r117973: <http://trac.webkit.org/changeset/117973>