Bug 87129 - Remove getPropertyShorthand from the web exposed API.
Summary: Remove getPropertyShorthand from the web exposed API.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on: 98916
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-22 06:47 PDT by Alexis Menard (darktears)
Modified: 2022-11-14 00:18 PST (History)
15 users (show)

See Also:

Attachments
Patch (21.63 KB, patch)
2012-05-22 07:26 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Patch (22.47 KB, patch)
2012-05-22 08:13 PDT, Alexis Menard (darktears) 		timothy: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-05-22 06:47:49 PDT 
Remove getPropertyShorthand from the web exposed API.
Comment 1 Alexis Menard (darktears) 2012-05-22 07:26:57 PDT 
Created attachment 143297 [details]
Patch
Comment 2 Build Bot 2012-05-22 08:06:24 PDT 
Comment on attachment 143297 [details]
Patch

Attachment 143297 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12764011
Comment 3 Alexis Menard (darktears) 2012-05-22 08:13:37 PDT 
Created attachment 143303 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-22 08:15:42 PDT 
Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API.
Comment 5 Timothy Hatcher 2012-05-22 12:46:05 PDT 
Comment on attachment 143303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143303&action=review

> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:-981
> -- (NSString *)getPropertyShorthand:(NSString *)propertyName AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER;

This is public API. It should stay, removing it is binary incompatible. If we wish to remove it we should mark it as deprecated for one release.
Comment 6 Alexis Menard (darktears) 2012-05-28 05:05:51 PDT 
I saw you guys branched for Safari, is there a way to mark it deprecated there and remove it here in trunk? I don't how work the releases inside Apple but that's a random thought.
Comment 7 Timothy Hatcher 2012-05-28 11:18:30 PDT 
It should be deprecated in trunk.
Comment 8 Sam Sneddon [:gsnedders] 2020-10-12 11:04:48 PDT 
Assuming Alexis is no longer working on this after eight years, so unassigning.

I believe this exists for the sake of Web Inspector, so Brian probably cares.
Comment 9 Ahmad Saleem 2022-08-12 12:07:32 PDT 
This still exist:

https://github.com/WebKit/WebKit/blob/b336a53b180ca88e40fef99e7f0a0779bd3d5986/Source/WebCore/css/CSSStyleDeclaration.idl#L42

Is it removed from all browsers? (Just for my learning). Thanks!
Comment 10 Radar WebKit Bug Importer 2022-11-13 21:30:52 PST 
<rdar://problem/102303976>
Comment 11 Darin Adler 2022-11-13 22:38:07 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6456
Comment 12 EWS 2022-11-14 00:18:47 PST 
Committed 256636@main (80c7a3df3ee1): <https://commits.webkit.org/256636@main>

Reviewed commits have been landed. Closing PR #6456 and removing active labels.