Bug 87129 - Remove getPropertyShorthand from the web exposed API.
Summary: Remove getPropertyShorthand from the web exposed API.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
Depends on: 98916
  Show dependency treegraph
Reported: 2012-05-22 06:47 PDT by Alexis Menard (darktears)
Modified: 2020-10-12 11:07 PDT (History)
9 users (show)

See Also:

Patch (21.63 KB, patch)
2012-05-22 07:26 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch (22.47 KB, patch)
2012-05-22 08:13 PDT, Alexis Menard (darktears)
timothy: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-05-22 06:47:49 PDT
Remove getPropertyShorthand from the web exposed API.
Comment 1 Alexis Menard (darktears) 2012-05-22 07:26:57 PDT
Created attachment 143297 [details]
Comment 2 Build Bot 2012-05-22 08:06:24 PDT
Comment on attachment 143297 [details]

Attachment 143297 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12764011
Comment 3 Alexis Menard (darktears) 2012-05-22 08:13:37 PDT
Created attachment 143303 [details]
Comment 4 WebKit Review Bot 2012-05-22 08:15:42 PDT
Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API.
Comment 5 Timothy Hatcher 2012-05-22 12:46:05 PDT
Comment on attachment 143303 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=143303&action=review

> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:-981
> -- (NSString *)getPropertyShorthand:(NSString *)propertyName AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER;

This is public API. It should stay, removing it is binary incompatible. If we wish to remove it we should mark it as deprecated for one release.
Comment 6 Alexis Menard (darktears) 2012-05-28 05:05:51 PDT
I saw you guys branched for Safari, is there a way to mark it deprecated there and remove it here in trunk? I don't how work the releases inside Apple but that's a random thought.
Comment 7 Timothy Hatcher 2012-05-28 11:18:30 PDT
It should be deprecated in trunk.
Comment 8 Sam Sneddon [:gsnedders] 2020-10-12 11:04:48 PDT
Assuming Alexis is no longer working on this after eight years, so unassigning.

I believe this exists for the sake of Web Inspector, so Brian probably cares.