Bug 87125 - [BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
Summary: [BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konrad Piascik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 06:13 PDT by Konrad Piascik
Modified: 2012-05-22 09:31 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.11 KB, patch)
2012-05-22 06:20 PDT, Konrad Piascik
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Piascik 2012-05-22 06:13:39 PDT
[BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
Comment 1 Konrad Piascik 2012-05-22 06:20:13 PDT
Created attachment 143292 [details]
Patch
Comment 2 Rob Buis 2012-05-22 08:27:34 PDT
Comment on attachment 143292 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-05-22 08:44:17 PDT
Comment on attachment 143292 [details]
Patch

Rejecting attachment 143292 [details] from commit-queue.

kpiascik@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Review Bot 2012-05-22 09:31:40 PDT
Comment on attachment 143292 [details]
Patch

Clearing flags on attachment: 143292

Committed r117985: <http://trac.webkit.org/changeset/117985>
Comment 5 WebKit Review Bot 2012-05-22 09:31:44 PDT
All reviewed patches have been landed.  Closing bug.