RESOLVED FIXED 87124
Web Inspector: HeapSnapshot: speed-up calculateRetainedSize functon. 
https://bugs.webkit.org/show_bug.cgi?id=87124
Summary Web Inspector: HeapSnapshot: speed-up calculateRetainedSize functon.
Ilya Tikhonovsky
Reported 2012-05-22 05:54:59 PDT
I found that in all dominators related functions we use nodeOrdinals. At the moment we divide nodeIndex to nodeFieldCount and this operation too expensive for these simple algorithms.
Attachments
Patch (11.11 KB, patch)
2012-05-22 06:11 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-22 06:03:31 PDT
RESULT heap-snapshot: _calculateRetainedSizes= 245 ms RESULT heap-snapshot: _buildDominatedNodes= 33 ms vs RESULT heap-snapshot: _calculateRetainedSizes= 87 ms RESULT heap-snapshot: _buildDominatedNodes= 15 ms
Ilya Tikhonovsky
Comment 2 2012-05-22 06:11:54 PDT
Created attachment 143290 [details] Patch
Yury Semikhatsky
Comment 3 2012-05-22 06:14:50 PDT
Comment on attachment 143290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143290&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:462 > + return this._snapshot._dominatorsTree[this.nodeIndex / this._snapshot._nodeFieldCount] * nodeFieldCount; this._snapshot._nodeFieldCount -> nodeFieldCount
Ilya Tikhonovsky
Comment 4 2012-05-22 06:25:10 PDT
Committed r117962: <http://trac.webkit.org/changeset/117962>
Note You need to log in before you can comment on or make changes to this bug.