Bug 87124 - Web Inspector: HeapSnapshot: speed-up calculateRetainedSize functon.
Summary: Web Inspector: HeapSnapshot: speed-up calculateRetainedSize functon.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 87107
  Show dependency tree / graph
 
Reported: 2012-05-22 05:54 PDT by Ilya Tikhonovsky
Modified: 2012-05-22 07:21 PDT (History)
11 users (show)

See Also:

Attachments
Patch (11.11 KB, patch)
2012-05-22 06:11 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-22 05:54:59 PDT 
I found that in all dominators related functions we use nodeOrdinals.
At the moment we divide nodeIndex to nodeFieldCount and this operation too expensive for these simple algorithms.
Comment 1 Ilya Tikhonovsky 2012-05-22 06:03:31 PDT 
RESULT heap-snapshot: _calculateRetainedSizes= 245 ms
RESULT heap-snapshot: _buildDominatedNodes= 33 ms

vs

RESULT heap-snapshot: _calculateRetainedSizes= 87 ms
RESULT heap-snapshot: _buildDominatedNodes= 15 ms
Comment 2 Ilya Tikhonovsky 2012-05-22 06:11:54 PDT 
Created attachment 143290 [details]
Patch
Comment 3 Yury Semikhatsky 2012-05-22 06:14:50 PDT 
Comment on attachment 143290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143290&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:462
> +        return this._snapshot._dominatorsTree[this.nodeIndex / this._snapshot._nodeFieldCount] * nodeFieldCount;

this._snapshot._nodeFieldCount ->  nodeFieldCount
Comment 4 Ilya Tikhonovsky 2012-05-22 06:25:10 PDT 
Committed r117962: <http://trac.webkit.org/changeset/117962>