Bug 87120 - Web Inspector: annotate InjectedScriptSource.js for closure compiler
Summary: Web Inspector: annotate InjectedScriptSource.js for closure compiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 05:30 PDT by Yury Semikhatsky
Modified: 2012-05-22 06:06 PDT (History)
12 users (show)

See Also:


Attachments
Patch (11.72 KB, patch)
2012-05-22 05:40 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-22 05:30:48 PDT
As Andrey Adaikin pointed out there is call of undefined function this._isPrimitiveValue in InjectedScript.wrapObject. Errors like this can be easily caught with the compiler.
Comment 1 Yury Semikhatsky 2012-05-22 05:40:24 PDT
Created attachment 143284 [details]
Patch
Comment 2 Pavel Feldman 2012-05-22 05:46:18 PDT
Comment on attachment 143284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143284&action=review

> Source/WebCore/inspector/InjectedScriptExterns.js:40
> +InjectedScriptHost.prototype.storageId = function(object) {}

{ }

> Source/WebCore/inspector/compile-injected-script.sh:32
> +java -jar ~/closure/compiler.jar\

could you merge it with the main compiler script instead?
Comment 3 Yury Semikhatsky 2012-05-22 05:56:52 PDT
(In reply to comment #2)
> (From update of attachment 143284 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143284&action=review
> 
> > Source/WebCore/inspector/InjectedScriptExterns.js:40
> > +InjectedScriptHost.prototype.storageId = function(object) {}
> 
> { }
> 
Done.

> > Source/WebCore/inspector/compile-injected-script.sh:32
> > +java -jar ~/closure/compiler.jar\
> 
> could you merge it with the main compiler script instead?
Done.
Comment 4 Yury Semikhatsky 2012-05-22 06:06:33 PDT
Committed r117961: <http://trac.webkit.org/changeset/117961>