RESOLVED FIXED 87100
[EFL] Gardening editing/style tests, missing baselines. 
https://bugs.webkit.org/show_bug.cgi?id=87100
Summary [EFL] Gardening editing/style tests, missing baselines.
Krzysztof Czech
Reported 2012-05-22 01:36:07 PDT
Added tests regarding 84839 bug, missing baselines.
Attachments
Gardening editing/style tests, missing baselines. (1.51 KB, patch)
2012-05-22 01:37 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Gardening editing/style tests, missing baselines. (1.40 KB, patch)
2012-05-23 03:11 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2012-05-22 01:37:49 PDT
Created attachment 143227 [details] Gardening editing/style tests, missing baselines.
WebKit Review Bot
Comment 2 2012-05-22 01:40:57 PDT
Attachment 143227 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/efl/test_expectations.txt:119: fast/events/show-modal-dialog-onblur-onfocus.html is also in a Skipped file. [test/expectations] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Grzegorz Czajkowski
Comment 3 2012-05-23 00:05:19 PDT
Patch https://bugs.webkit.org/show_bug.cgi?id=87103 resolves style issue. Please rebase it and add cq flag again.
Krzysztof Czech
Comment 4 2012-05-23 03:11:43 PDT
Created attachment 143516 [details] Gardening editing/style tests, missing baselines.
Grzegorz Czajkowski
Comment 5 2012-05-23 03:21:58 PDT
Comment on attachment 143516 [details] Gardening editing/style tests, missing baselines. LGTM, Thanks.
WebKit Review Bot
Comment 6 2012-05-23 03:55:31 PDT
Comment on attachment 143516 [details] Gardening editing/style tests, missing baselines. Clearing flags on attachment: 143516 Committed r118157: <http://trac.webkit.org/changeset/118157>
WebKit Review Bot
Comment 7 2012-05-23 03:55:42 PDT
All reviewed patches have been landed. Closing bug.
Grzegorz Czajkowski
Comment 8 2012-05-23 06:49:33 PDT
Reverted r118157 for reason: Tests are not connected to 8483 bug Committed r118172: <http://trac.webkit.org/changeset/118172>
Gyuyoung Kim
Comment 9 2012-07-27 18:35:53 PDT
It looks this patch was landed. So, close this bug.
Note You need to log in before you can comment on or make changes to this bug.