Bug 87098 - Web Inspector: allow showing selected object in another heap profiler view
Summary: Web Inspector: allow showing selected object in another heap profiler view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 01:33 PDT by Yury Semikhatsky
Modified: 2012-05-22 02:53 PDT (History)
11 users (show)

See Also:

Attachments
Patch (11.76 KB, patch)
2012-05-22 02:18 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (11.52 KB, patch)
2012-05-22 02:19 PDT, Yury Semikhatsky 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-22 01:33:22 PDT 
It is useful to have an option to jump from a heap node in the heap snapshot Summary view to the same node in the Dominators view and backwards.
Comment 1 Yury Semikhatsky 2012-05-22 02:18:14 PDT 
Created attachment 143237 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-22 02:19:18 PDT 
Created attachment 143238 [details]
Patch
Comment 3 Ilya Tikhonovsky 2012-05-22 02:27:13 PDT 
Comment on attachment 143237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143237&action=review

lgtm

> Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:450
> +

please remove this
Comment 4 Yury Semikhatsky 2012-05-22 02:35:05 PDT 
(In reply to comment #3)
> (From update of attachment 143237 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143237&action=review
> 
> lgtm
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:450
> > +
> 
> please remove this

Done.
Comment 5 Vsevolod Vlasov 2012-05-22 02:44:58 PDT 
Comment on attachment 143238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143238&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:51
> +    this.addEventListener("sorting complete", this._sortingComplete, this);

This event is not used anywhere but in this class, could you replace it with a private method instead?
Comment 6 Yury Semikhatsky 2012-05-22 02:51:53 PDT 
(In reply to comment #5)
> (From update of attachment 143238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143238&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:51
> > +    this.addEventListener("sorting complete", this._sortingComplete, this);
> 
> This event is not used anywhere but in this class, could you replace it with a private method instead?

It is used in layout tests for tracking the moment when sorting completes so I'm going to leave it for now.
Comment 7 Yury Semikhatsky 2012-05-22 02:53:05 PDT 
Committed r117940: <http://trac.webkit.org/changeset/117940>