RESOLVED FIXED 87098
Web Inspector: allow showing selected object in another heap profiler view 
https://bugs.webkit.org/show_bug.cgi?id=87098
Summary Web Inspector: allow showing selected object in another heap profiler view
Yury Semikhatsky
Reported 2012-05-22 01:33:22 PDT
It is useful to have an option to jump from a heap node in the heap snapshot Summary view to the same node in the Dominators view and backwards.
Attachments
Patch (11.76 KB, patch)
2012-05-22 02:18 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (11.52 KB, patch)
2012-05-22 02:19 PDT, Yury Semikhatsky 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-05-22 02:18:14 PDT
Created attachment 143237 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-22 02:19:18 PDT
Created attachment 143238 [details] Patch
Ilya Tikhonovsky
Comment 3 2012-05-22 02:27:13 PDT
Comment on attachment 143237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143237&action=review lgtm > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:450 > + please remove this
Yury Semikhatsky
Comment 4 2012-05-22 02:35:05 PDT
(In reply to comment #3) > (From update of attachment 143237 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143237&action=review > > lgtm > > > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:450 > > + > > please remove this Done.
Vsevolod Vlasov
Comment 5 2012-05-22 02:44:58 PDT
Comment on attachment 143238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143238&action=review > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:51 > + this.addEventListener("sorting complete", this._sortingComplete, this); This event is not used anywhere but in this class, could you replace it with a private method instead?
Yury Semikhatsky
Comment 6 2012-05-22 02:51:53 PDT
(In reply to comment #5) > (From update of attachment 143238 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143238&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:51 > > + this.addEventListener("sorting complete", this._sortingComplete, this); > > This event is not used anywhere but in this class, could you replace it with a private method instead? It is used in layout tests for tracking the moment when sorting completes so I'm going to leave it for now.
Yury Semikhatsky
Comment 7 2012-05-22 02:53:05 PDT
Committed r117940: <http://trac.webkit.org/changeset/117940>
Note You need to log in before you can comment on or make changes to this bug.