Bug 87093 - [EFL] Style issue due to tests duplicated in Skipped in test_expectations.txt
Summary: [EFL] Style issue due to tests duplicated in Skipped in test_expectations.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 00:46 PDT by Chris Dumez
Modified: 2012-05-22 04:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.52 KB, patch)
2012-05-22 00:47 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-22 00:46:04 PDT
The style script is complaining about the following tests:

LayoutTests/platform/efl/test_expectations.txt:6:  fast/dom/shadow/content-element-api.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:7:  fast/dom/shadow/content-element-outside-shadow.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:38:  editing/pasteboard/drag-files-to-editable-element.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:42:  fast/events/drop-handler-should-not-stop-navigate.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:43:  fast/events/drop-with-file-paths.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:44:  fast/files/file-reader-directory-crash.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:119:  fast/events/show-modal-dialog-onblur-onfocus.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:120:  fast/harness/show-modal-dialog.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:286:  fast/dom/title-directionality.html is also in a Skipped file.  [test/expectations] [5]
Comment 1 Chris Dumez 2012-05-22 00:47:45 PDT
Created attachment 143216 [details]
Patch

Could someone please cq+ ?
Comment 2 Grzegorz Czajkowski 2012-05-22 00:54:40 PDT
Comment on attachment 143216 [details]
Patch

LGTM. Thanks.
Comment 3 WebKit Review Bot 2012-05-22 01:35:34 PDT
Comment on attachment 143216 [details]
Patch

Clearing flags on attachment: 143216

Committed r117932: <http://trac.webkit.org/changeset/117932>
Comment 4 WebKit Review Bot 2012-05-22 01:35:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Thiago Marcos P. Santos 2012-05-22 03:55:55 PDT
Two new failures after this patch:

fast/events/drop-handler-should-not-stop-navigate.html = TEXT
fast/files/file-reader-directory-crash.html = TEXT
Comment 6 Chris Dumez 2012-05-22 04:04:32 PDT
Will address the issue in Bug 87115.