Bug 87088 - Disable private names by default in WebCore
Summary: Disable private names by default in WebCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2012-05-21 23:44 PDT by Gavin Barraclough
Modified: 2012-05-22 23:43 PDT (History)
4 users (show)

See Also:

Fix (28.89 KB, patch)
2012-05-22 00:09 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-05-21 23:44:07 PDT
r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.  These are probably not yet ready to be web-facing, so disabling by default in WebCore.
Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
Comment 1 Gavin Barraclough 2012-05-22 00:09:47 PDT
Created attachment 143206 [details]
Comment 2 Geoffrey Garen 2012-05-22 11:41:29 PDT
Comment on attachment 143206 [details]

Comment 3 Gavin Barraclough 2012-05-22 12:09:54 PDT
Fixed in r118018
Comment 4 Csaba Osztrogonác 2012-05-22 23:43:47 PDT
After disabling private names, fast/js/names.html started to fail on GTK and Qt, because r118018 made the necessarry changes to be able run this test for Mac only. 

I skipped this test on Qt - r118130.